Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(searchbar): properly align placeholder #20460

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 12, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20456

What is the new behavior?

  • Ensured that placeholder content is being interpreted as plain text.
  • Also added an raf to help with race conditions when getting the width of the temporary span. It doesn't 100% fix the issue, but it significantly helps.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 12, 2020
@brandyscarney
Copy link
Member

Code looks fine, can you ping me when screenshot finishes or include a before & after in a test?

@liamdebeasi
Copy link
Contributor Author

master searchbar-pos
localhost_3333_src_components_searchbar_test_basic(Pixel 2 XL) (1) localhost_3333_src_components_searchbar_test_basic(Pixel 2 XL)

@liamdebeasi liamdebeasi merged commit 4d6e15a into master Feb 12, 2020
@liamdebeasi liamdebeasi deleted the searchbar-pos branch February 12, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants