Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slides): set height to 100% for vertical slides #20603

Merged
merged 2 commits into from Feb 26, 2020

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Feb 24, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Slides doesn't take up a set height so it will show some of the inactive slides when direction is set to vertical

Issue Number: fixes #17341

Dev build: 5.1.0-dev.202002241801.ce23bbc

What is the new behavior?

This sets the slides height to 100% which will ensure that only the active slide is visible until swiping.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 24, 2020
@brandyscarney brandyscarney merged commit 20af652 into master Feb 26, 2020
@brandyscarney brandyscarney deleted the fix-vertical-slides branch February 26, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ion-slides vertical not working v4
1 participant