Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buttons): use proper button colors with variables set inside of a toolbar #20633

Merged
merged 8 commits into from Feb 27, 2020

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Feb 27, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Ran into issues during the conference app redesign & realized that certain variables when set for buttons in a toolbar did not behave as expected. You can see the below & after images in the next section. The test is under toolbar/custom.

Issue Number: N/A

What is the new behavior?

master branch
android-master android-branch
ios-master ios-branch

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 27, 2020
@brandyscarney brandyscarney merged commit c1d7bf2 into master Feb 27, 2020
@brandyscarney brandyscarney deleted the fix-button-color-in-toolbar branch February 27, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants