Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(label): text overflow for slotted headings #20690

Merged
merged 3 commits into from Mar 11, 2020
Merged

fix(label): text overflow for slotted headings #20690

merged 3 commits into from Mar 11, 2020

Conversation

simonhaenisch
Copy link
Contributor

@simonhaenisch simonhaenisch commented Mar 4, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Headings that are put in the slot of an ion-label don't inherit the text-overflow: ellipsis style.

Issue Number: #17087.

What is the new behavior?

  • Adds styling for slotted headings to inherit overflow and text-overflow.

Does this introduce a breaking change?

  • Yes
  • No

If anyone really wanted headings inside labels to just have hidden overflow (very unlikely), they'd need to explicitly set the overflow.

Other information

Closes #17087.

master branch
master branch

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Mar 4, 2020
@brandyscarney brandyscarney self-requested a review March 10, 2020 15:12
@brandyscarney
Copy link
Member

This looks good! Thank you! I made a small change to the test just to reduce the amount of words so that it would all fit in the screenshot. 🙂

@brandyscarney brandyscarney merged commit 4d34ce6 into ionic-team:master Mar 11, 2020
@simonhaenisch simonhaenisch deleted the fix-ion-label-headings branch March 11, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

headings in ion-labels don't inherit overflow and text-overflow
2 participants