Make the MIME fields for attachments accessible from the plugin #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch doesn't break retrocompatibility. When passing an hashref to the attachment, pass the hash to MIME::Entity, complaining if Path is missing. If a string is passed, the original routine is used. The example in the documentation has been changed to show a possible use (embedding CID images in HTML mails).
|
Sorry, I had forgot to reply to this. It is very hard for me to review this because the indention is way off. Please fix the indentation to match the existing indentation style so that I can review this. Thanks. |
|
The tab-width was set to 8. Now I have untabified it and should display correctly, thanks. |
|
Works great. Thanks! |
ironcamel
added a commit
that referenced
this pull request
Mar 9, 2013
Make the MIME fields for attachments accessible from the plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch doesn't break retrocompatibility. When passing an hashref
to the attachment, pass the hash to MIME::Entity, complaining if Path
is missing.
If a string is passed, the original routine is used.
The example in the documentation has been changed to show a possible
use (embedding CID images in HTML mails).