Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Pass I: General Part IV #348

Open
5 tasks
jenmaxwell opened this issue May 15, 2018 · 1 comment
Open
5 tasks

GUI Pass I: General Part IV #348

jenmaxwell opened this issue May 15, 2018 · 1 comment

Comments

@jenmaxwell
Copy link
Contributor

jenmaxwell commented May 15, 2018

Part IV for the GUI folder general notes

vcDeleteObject

  • Assign someone to fix the example (objects are not instantiated to delete...)
  • Review added text. Particularly outputs section.

vcDeleteSelectedObject

  • Assign someone to fix the example (objects are not instantiated to delete...)
  • Review added text. Particularly outputs section.

vcEquivalentObjtype

  • Should this be vcEquivalentObjType?
  • Should we include an 'else' case with an error? - I think so, but convincing me otherwise shouldn't be too difficult.
  • Changed to lower instead of upper.

vcGetFigure

  • Why do we have vcEquivalentObjtype convert to upper when in the switch case here we convert to lower? Which format would you prefer to follow? Personally I'd take lower as it is used elsewhere throughout the project. Going back to change to lower. Can revert if desired.
  • Assign someone to fix the example. The object obj is neither instantiated nor displayed.

vcGetObjectNames

  • Assign someone to flesh out example.
  • Confirm function works as designed, as empty return even with existing oi objects is what I found?

vcGetObjects

  • Assign someone to flesh out example?
  • Confirm return types?
@jenmaxwell
Copy link
Contributor Author

Updated 11/26 to switch to task format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant