fix: isPromiseFs out-of-spec usage of readFile #1857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the odd Deno behavior described in #1851 by explicitly passing
undefined
toreadFile
, so thepromisify
wrapper works properly.This does seem to be a Deno bug (denoland/deno#21795), but it's also an emergent behavior of isomorphic-git calling
readFile
out-of-spec + promisfy's inability to identify that because it is unaware of intended method signatures (resulting in a place where IMO JavaScript's correct error behavior is under-specified). This workaround getsisPromsseFs
working on Deno, and that + manually addingBuffer
toglobalThis
is enough to get isomorphic-git working on Deno for my use case.Full Deno support (including running the tests) would be a much larger effort. Closes #1851.
I'm fixing a bug or typo
npm run add-contributor
and follow the prompts to add yourself to the README