Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing a file happens without saving changes. :( #1566

Open
TangentFoxy opened this issue Mar 16, 2024 · 0 comments
Open

Replacing a file happens without saving changes. :( #1566

TangentFoxy opened this issue Mar 16, 2024 · 0 comments
Labels

Comments

@TangentFoxy
Copy link

Describe the bug
I was updating an embedded webpage project that was created in 2015, and to test without breaking things if my new version failed, I decided to temporarily uncheck "This file will be played in the browser" and then hide the old version. Then I uploaded the new version, which happened to have the same filename, and this visually replaced the old version I had just hidden. I decided to refresh the page without saving changes in order to undo this error, but the old version was permanently deleted as far as I can tell, and replaced with the new version.

While I believe I saw that this is intended behavior in general (I think I saw a warning about this in documentation somewhere), it's been long enough (years) since I looked that I forgot and did not expect this behavior. Additionally, I think it's unfair that refreshing the page without having saved changes still did this and that there was no warning during the upload process to confirm I wanted the old file replaced.

Expected behavior
At least warn us before accepting a file that will cause a replacement? I would prefer if uploading a file didn't immediately apply without saving changes, because every other option on the edit page doesn't apply until you click Save, but I understand if that's infeasible. (I would prefer not replacing the file at all, but I understand this is expected behavior for the majority and would probably destroy workflows if changed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant