Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content hidden by CSS max-height rule in host list #1398

Open
psyray opened this issue Jul 15, 2022 · 4 comments · Fixed by #1401
Open

Content hidden by CSS max-height rule in host list #1398

psyray opened this issue Jul 15, 2022 · 4 comments · Fixed by #1401

Comments

@psyray
Copy link
Contributor

psyray commented Jul 15, 2022

IVRE Version

$ ivre version
IVRE - Network recon framework
Copyright 2011 - 2022 Pierre LALET <pierre@droids-corp.org>
Version 0.9.18.dev25-dockerhub

Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110]

Linux 2f86dcf6bc91 4.9.0-19-amd64 #1 SMP Debian 4.9.320-2 (2022-06-30) x86_64

Dependencies:
    Python module pymongo: 3.11.0
    Python module sqlalchemy: missing
    Python module psycopg2: missing
    Python module cryptography: 3.3.2
    Python module krbV: missing
    Python module pycurl: missing
    Python module PIL: 8.1.2
    Python module MySQLdb: missing
    Python module dbus: missing
    Python module matplotlib: missing
    Python module bottle: 0.12.19
    Python module OpenSSL: 20.0.1
    Python module tinydb: missing

Summary

Due to a CSS max-height value, content is hidden in the host list

Expected behavior

See full content in the box

Actual behavior

Content hidden

How to reproduce

List host with a lot of content

More

With max-height
image

Without
image

@p-l-
Copy link
Member

p-l- commented Jul 15, 2022

This is meant to avoid a "summary" that would use too much space. You can see that I am far from being a frontend dev :)

Feel free to submit a PR if you feel like it should change.

@psyray
Copy link
Contributor Author

psyray commented Jul 17, 2022

I understand ;)
And I think this could be enhanced, I will have a look and submit a PR ;)
And I will also enhance the display for the Explore View.
If labels are too large we can't see them in full.
And when clicking it doesn't filter the result like other Explore view
image

@psyray
Copy link
Contributor Author

psyray commented Jul 17, 2022

This is meant to avoid a "summary" that would use too much space. You can see that I am far from being a frontend dev :)

Feel free to submit a PR if you feel like it should change.

Instead of putting an overflow: hidden, I could put an overflow: scroll in the ivre.css, line 142

overflow: hidden;

With that we could scroll the entire list, in preview mode, and if a box content overflow it shows a scroll, and we could scroll inside this huge box.
So, this way, no information is lost in preview mode

What do you think of this ?

Result is
image

@p-l-
Copy link
Member

p-l- commented Jul 20, 2022

Fix reverted in #1407.

@p-l- p-l- reopened this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants