Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueConstraints aren't stored and validated #171

Open
wjzijderveld opened this issue Jan 20, 2014 · 1 comment
Open

ValueConstraints aren't stored and validated #171

wjzijderveld opened this issue Jan 20, 2014 · 1 comment
Labels

Comments

@wjzijderveld
Copy link

While working on a blogpost about custom NodeTypes, I encountered an issue with the ValueConstraints.

It seems they aren't stored anywhere, and I couldn't find a trace in the code where they would be validated.
Are they supposed to be stored and validated?

@dbu
Copy link
Member

dbu commented Jan 20, 2014

there is Client::validateNode which in the end goes into assertValidProperty - but reading that one i saw no mention of ValueConstraint so indeed we might miss bits here. i think we do call validateNode in all places we have to call it, but am not 100% sure of that either.

i guess the way to fix this would be to add tests to phpcr-api-tests that use this feature. they should succeed in jackalope-jackrabbit as the jackrabbit backend is supposed to do things correctly. then run those tests against jackalope-doctrine-dbal and you likely see constraints not applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants