Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages #225

Open
dantleech opened this issue Apr 5, 2014 · 4 comments
Open

Improve error messages #225

dantleech opened this issue Apr 5, 2014 · 4 comments

Comments

@dantleech
Copy link
Contributor

For example:

No explanation about what exception is about:

 Property dcms:foo in /dcms/sites/dantleech/bar

No parenthis around property name "format":

[PHPCR\RepositoryException] No default value for autocreated property format at /slinp/web/root/articles/Faster-than-light

Is a PathNotFoundException. Without looking at the code I don't really know what it is actually saying to me.

We should probably do an audit and clean up the error messages generally.

@dantleech
Copy link
Contributor Author

Was just about to create this issue again, putting it on my todo :)

@dbu
Copy link
Member

dbu commented May 16, 2014

looks like some exceptions where expecting the reader to also see the exception class. definitely room for improvement.

@dbu
Copy link
Member

dbu commented May 16, 2014

just be careful about changing the exception type thrown - BC break risks, and PHPCR actually defines what exceptions to expect where (though we surely don't test that and there will be glitches currently)

@dantleech
Copy link
Contributor Author

I was thinking just about changing the messagws to be "self sufficient" and being more helpful (like saying which choices are available in enum fields f e.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants