Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary calls to .contiguous() hurt performance #19

Open
jacobhinkle opened this issue Jun 25, 2020 · 0 comments
Open

Unnecessary calls to .contiguous() hurt performance #19

jacobhinkle opened this issue Jun 25, 2020 · 0 comments

Comments

@jacobhinkle
Copy link
Owner

Describe the bug
There are many times in our python code where we force tensors to be contiguous. This is because before pytorch introduced packed_accessor it was pretty annoying to use strided tensors when writing extensions

Expected behavior
We should be able to run most operations on strided tensors without copies.

Solution
We just need to convert most of our kernels and calling code to use packed_accessor32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant