-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for Uniform Number #68
Comments
@dylanavery720 this is a good idea! So for season totals, the web page that is scraped is something like https://www.basketball-reference.com/leagues/NBA_2019_totals.html. Because of that, I'm restricted by what's actually on the web page. Unfortunately, uniform number isn't really something that's available. I did notice that there is a uniform numbers web page (https://www.basketball-reference.com/leagues/NBA_2019_numbers.html) but other than that I can't see or think of a suitable solution for returning uniform numbers across all players for a given season. One thing that could be done is adding a Hope this helps! |
Hey @jaebradley , jumping in here, this issue has been open for a while. Has any work been done on some sort of |
@tomkennedy22 nope, there hasn't been any work here - I've done some work to parse the player page in certain cases for the search API where basketball reference redirects to a specific player page when a single player matches a search query. See: basketball_reference_web_scraper/basketball_reference_web_scraper/http_service.py Line 193 in 601fad5
Hope that provides at least a bit of a start - let me know if you have any questions! |
Hi @jaebradley ,
I was wondering if you had thought about adding the Uniform Number of a player to the HTTP response for season_totals. (So for Lebron James it would be {number: 23} for instance)
I think it would be very useful!
Dylan
The text was updated successfully, but these errors were encountered: