Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Webpack Encore support or filename definition capability #281

Open
tropicalraisel opened this issue Aug 18, 2021 · 2 comments
Labels

Comments

@tropicalraisel
Copy link

tropicalraisel commented Aug 18, 2021

Is your feature request related to a problem? Please describe.
When using this plugin alongside Webpack Encore and its copyFiles or configureImageRule functionality, the favicons are generated in their plain filenames, even if custom name definitions have been set for all files.

Describe the solution you'd like
Favicons to be generated in a way that matches a custom definition, like [name].[hash:8].[ext]. It would be nice if this plugin could detect settings preset like so:

Encore.configureImageRule({
    type: 'asset',
    filename: 'images/[name].[hash:8][ext]'
  })

or

Encore.copyFiles({
    from: './assets/images',
    to: 'images/[path][name].[hash:8].[ext]'
  })

Describe alternatives you've considered
Any alternatives would involve post-processing, which should not be necessary.

Additional context
N/A

@jantimon
Copy link
Owner

Cool idea :)

Feel free to add that feature

@stale
Copy link

stale bot commented Apr 18, 2022

This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days.

@stale stale bot added the wontfix label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants