Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contenthash] should consider content of manifests #294

Open
peterhirn opened this issue Dec 22, 2021 · 1 comment
Open

[contenthash] should consider content of manifests #294

peterhirn opened this issue Dec 22, 2021 · 1 comment
Labels
bug

Comments

@peterhirn
Copy link

peterhirn commented Dec 22, 2021 •
edited

Changes to appName, appShortName, etc. and file changes to manifest currently don't affect the content hash. This means the folder can not be safely cached by clients and the prefix needs to be manually updated with every config change, eg. prefix: "assets/[contenthash:8]-v2/".

The [contenthash] should be constructed by hashing input files + full config (including defaults) or alternatively hashing of the output files.
@jantimon
Copy link
Owner

Could you please create a PR?

@andy128k andy128k added the bug label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andy128k @peterhirn @jantimon