Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No options passed to the exchange functions #183

Open
mahsa-motherco opened this issue Sep 13, 2016 · 1 comment
Open

No options passed to the exchange functions #183

mahsa-motherco opened this issue Sep 13, 2016 · 1 comment

Comments

@mahsa-motherco
Copy link

mahsa-motherco commented Sep 13, 2016

Hello,

I have noticed an issue in the code while I was trying to setup the password exchange.

I need to set the options.userProperty of the exchange/password.js file (this line), so that it does not my user property in my request, however, I noticed that the other functions which call the exchange function, do not pass my option variable to it. For this case, I am using middleware/token.js with the options I need, however, it seems that the server._exchange never passes my options (this line and this line).
Also, I tried to send my options at the time I am passing my issue function to the exchange, as the first argument, however, the exchange function in the server.js file, only gets issue function and the exchange type, but not the options value (line).

I believe this issue is true for all the four exchanges we have, and someone needs to modify the options value as needed, but they cannot. I think either of the above approaches (options as an argument to exchange function or passing options to the server._exchange or both) can be a solution.

This open issue is also related to my issue and I tried to use the userProperty to address the aforementioned issue.

Thank you for your attention.

@ddannenb
Copy link

Ran into the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants