Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passReqToCallback slightly inconsistent with Express, doc update? #133

Open
dgolant opened this issue May 31, 2018 · 1 comment
Open

passReqToCallback slightly inconsistent with Express, doc update? #133

dgolant opened this issue May 31, 2018 · 1 comment

Comments

@dgolant
Copy link

dgolant commented May 31, 2018

Hi,

I just dealt with a minor annoyance for an hour, figured I would share in case it was valuable for docs. When passing the passReqToCallback argument to a strat, the "incoming" query params are accessible through req.params. In Express, query params come through on req.query. In the callback/handler in the google strategy, req.query stores a state and code key, which makes it seem as though req.query is being overwritten even when passReqToCallback is true. Happy to update docs as long as this confusion isn't based solely in my own denseness 👍 .

@dgolant
Copy link
Author

dgolant commented Jun 3, 2018

Actually, I am not sure what I did (or if it ever worked, was tired when I did this), but this no longer even works for me. If I set passReqToCallback: true on the strategy, query comes through with state and code, but req.params comes through empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant