Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting google_analytics_gtag_identity does not work #225

Open
roerd opened this issue Feb 22, 2023 · 3 comments · May be fixed by #226
Open

Setting google_analytics_gtag_identity does not work #225

roerd opened this issue Feb 22, 2023 · 3 comments · May be fixed by #226
Labels

Comments

@roerd
Copy link

roerd commented Feb 22, 2023

Conflicting to the information in the documentation, changing the user id by setting the google_analytics_gtag_identity context key does not work, only analytical_identity works instead.

I suppose this is because the call to the get_identity function in google_analytics_gtag.py:60 is missing the prefix argument.

@bittner
Copy link
Member

bittner commented Feb 22, 2023

Thanks for reporting the issue. Do you want to open a PR to fix the problem?

@bittner bittner added the bug label Feb 22, 2023
@bittner
Copy link
Member

bittner commented Feb 22, 2023

Is this maybe related to #197?

@roerd
Copy link
Author

roerd commented Feb 23, 2023

Thanks for reporting the issue. Do you want to open a PR to fix the problem?

Right now, I don't have the repo for this project checked out, only the package pip-installed, so it might take some time until I get around to it. But if that's OK, I could do it.

Is this maybe related to #197?

It is kind of related (both issues are about sending the user id with GTAG), but not the same problem, no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants