forked from mozilla/zamboni
/
test_views.py
1532 lines (1231 loc) · 58 KB
/
test_views.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# -*- coding: utf8 -*-
from datetime import datetime, timedelta
import json
import re
import time
from django.conf import settings
from django.core import mail
from mock import patch, patch_object
from nose.tools import eq_
from pyquery import PyQuery as pq
import test_utils
from waffle.models import Switch
import amo
from amo.urlresolvers import reverse
from amo.tests import formset, initial
from addons.models import Addon, AddonUser
from applications.models import Application
from cake.urlresolvers import remora_url
from devhub.models import ActivityLog
from editors.models import EditorSubscription, EventLog
from files.models import Approval, Platform, File
import reviews
from reviews.models import Review, ReviewFlag
from users.models import UserProfile
from versions.models import Version, VersionSummary, AppVersion
from zadmin.models import set_config
from . test_models import create_addon_file
class EditorTest(test_utils.TestCase):
fixtures = ('base/users', 'editors/pending-queue', 'base/approvals')
def login_as_admin(self):
assert self.client.login(username='admin@mozilla.com',
password='password')
def login_as_editor(self):
assert self.client.login(username='editor@mozilla.com',
password='password')
def make_review(self, username='a'):
u = UserProfile.objects.create(username=username)
a = Addon.objects.create(name='yermom', type=amo.ADDON_EXTENSION)
return Review.objects.create(user=u, addon=a)
class TestEventLog(EditorTest):
def setUp(self):
self.login_as_editor()
amo.set_user(UserProfile.objects.get(username='editor'))
review = self.make_review()
for i in xrange(30):
amo.log(amo.LOG.APPROVE_REVIEW, review, review.addon)
amo.log(amo.LOG.DELETE_REVIEW, review.id, review.addon)
def test_log(self):
r = self.client.get(reverse('editors.eventlog'))
eq_(r.status_code, 200)
def test_start_filter(self):
r = self.client.get(reverse('editors.eventlog') + '?start=3011-01-01')
eq_(r.status_code, 200)
def test_enddate_filter(self):
"""
Make sure that if our end date is 1/1/2011, that we include items from
1/1/2011. To not do as such would be dishonorable.
"""
review = self.make_review(username='b')
amo.log(amo.LOG.APPROVE_REVIEW, review, review.addon,
created=datetime(2011, 1, 1))
r = self.client.get(reverse('editors.eventlog') + '?end=2011-01-01')
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('tbody td').eq(0).text(), 'Jan 1, 2011 12:00:00 AM')
def test_action_filter(self):
"""
Based on setup we should only see 30 items if we filter for deleted
reviews.
"""
r = self.client.get(reverse('editors.eventlog') + '?filter=deleted')
doc = pq(r.content)
eq_(len(doc('tbody tr')), 30)
def test_no_results(self):
r = self.client.get(reverse('editors.eventlog') + '?end=' +
'2004-01-01')
assert 'No events found for this period.' in r.content
def test_breadcrumbs(self):
r = self.client.get(reverse('editors.eventlog'))
doc = pq(r.content)
list_items = doc('ol.breadcrumbs li')
eq_(list_items.length, 2)
eq_(list_items.eq(0).find('a').text(), "Editor Tools")
eq_(list_items.eq(1).text(), "Event Log")
class TestEventLogDetail(TestEventLog):
def test_me(self):
id = ActivityLog.objects.editor_events()[0].id
r = self.client.get(reverse('editors.eventlog.detail', args=[id]))
eq_(r.status_code, 200)
class TestReviewLog(EditorTest):
def setUp(self):
self.login_as_editor()
def make_approvals(self, count=51):
Platform.objects.create(id=amo.PLATFORM_ALL.id)
u = UserProfile.objects.filter()[0]
for i in xrange(count):
a = Addon.objects.create(type=amo.ADDON_EXTENSION)
v = Version.objects.create(addon=a)
amo.log(amo.LOG.REJECT_VERSION, a, v, user=u,
details={'comments': 'youwin'})
def make_an_approval(self, action):
u = UserProfile.objects.filter()[0]
a = Addon.objects.create(type=amo.ADDON_EXTENSION)
v = Version.objects.create(addon=a)
amo.log(action, a, v, user=u, details={'comments': 'youwin'})
def test_basic(self):
self.make_approvals()
r = self.client.get(reverse('editors.reviewlog'))
eq_(r.status_code, 200)
doc = pq(r.content)
assert doc('.listing button'), 'No filters.'
# Should have 50 showing.
eq_(len(doc('tbody tr').not_('.hide')), 50)
eq_(doc('tbody tr.hide').eq(0).text(), 'youwin')
def test_xss(self):
u = UserProfile.objects.filter()[0]
a = Addon.objects.create(type=amo.ADDON_EXTENSION,
name="<script>alert('')</script>")
v = Version.objects.create(addon=a)
amo.log(amo.LOG.REJECT_VERSION, a, v, user=u,
details={'comments': 'xss!'})
self.make_approvals(count=0)
r = self.client.get(reverse('editors.reviewlog'))
eq_(r.status_code, 200)
doc = pq(r.content)
inner_html = doc('tbody tr td').eq(1).html()
assert "<script>" in inner_html
assert "<script>" not in inner_html
def test_end_filter(self):
"""
Let's use today as an end-day filter and make sure we see stuff if we
filter.
"""
self.make_approvals()
# Make sure we show the stuff we just made.
date = time.strftime('%Y-%m-%d')
r = self.client.get(reverse('editors.reviewlog') + '?end=' + date)
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(len(doc('tbody tr').not_('.hide')), 50)
eq_(doc('tbody tr.hide').eq(0).text(), 'youwin')
def test_end_filter_wrong(self):
"""
Let's use today as an end-day filter and make sure we see stuff if we
filter.
"""
self.make_approvals()
date = 'wrong!'
r = self.client.get(reverse('editors.reviewlog') + '?end=' + date)
# If this is broken, we'll get a traceback.
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('#log-listing tr:not(.hide)').length, 51)
def test_breadcrumbs(self):
r = self.client.get(reverse('editors.reviewlog'))
doc = pq(r.content)
list_items = doc('ol.breadcrumbs li')
eq_(list_items.length, 2)
eq_(list_items.eq(0).find('a').text(), "Editor Tools")
eq_(list_items.eq(1).text(), "Review Log")
@patch('devhub.models.ActivityLog.arguments')
def test_addon_missing(self, arguments):
self.make_approvals()
arguments.return_value = []
r = self.client.get(reverse('editors.reviewlog'))
doc = pq(r.content)
eq_(doc('#log-listing tr td')[1].text.strip(),
'Add-on has been deleted.')
def test_request_info_logs(self):
self.make_an_approval(amo.LOG.REQUEST_INFORMATION)
r = self.client.get(reverse('editors.reviewlog'))
doc = pq(r.content)
eq_(doc('#log-listing tr td a')[1].text.strip(),
'needs more information')
def test_super_review_logs(self):
self.make_an_approval(amo.LOG.REQUEST_SUPER_REVIEW)
r = self.client.get(reverse('editors.reviewlog'))
doc = pq(r.content)
eq_(doc('#log-listing tr td a')[1].text.strip(),
'needs super review')
class TestHome(EditorTest):
"""Test the page at /editors."""
def setUp(self):
self.login_as_editor()
self.user = UserProfile.objects.get(id=5497308)
self.user.display_name = 'editor'
self.user.save()
amo.set_user(self.user)
def approve_reviews(self):
Platform.objects.create(id=amo.PLATFORM_ALL.id)
u = self.user
now = datetime.now()
created = datetime(now.year - 1, now.month, 1)
for i in xrange(50):
a = Addon.objects.create(type=amo.ADDON_EXTENSION)
v = Version.objects.create(addon=a)
amo.set_user(u)
amo.log(amo.LOG['APPROVE_VERSION'], a, v)
def test_approved_review(self):
review = self.make_review()
amo.log(amo.LOG.APPROVE_REVIEW, review, review.addon)
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
eq_(doc('.row').eq(0).text().strip().split('.')[0],
'editor approved Review for yermom ')
def test_deleted_review(self):
review = self.make_review()
amo.log(amo.LOG.DELETE_REVIEW, review.id, review.addon)
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
eq_(doc('.row').eq(0).text().strip().split('.')[0],
'editor deleted review %d' % review.id)
def test_stats_total(self):
self.approve_reviews()
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
div = doc('#editors-stats .editor-stats-table:eq(1)')
display_name = div.find('td')[0].text
eq_(display_name, self.user.display_name)
approval_count = div.find('td')[1].text
eq_(int(approval_count), 50)
def test_stats_monthly(self):
self.approve_reviews()
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
div = doc('#editors-stats .editor-stats-table:eq(1)')
display_name = div.find('td')[0].text
eq_(display_name, self.user.display_name)
approval_count = div.find('td')[1].text
eq_(int(approval_count), 50)
def test_new_editors(self):
EventLog(type='admin', action='group_addmember', changed_id=2,
added=self.user.id, user=self.user).save()
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
div = doc('#editors-stats .editor-stats-table:eq(2)')
name = div.find('td a')[0].text.strip()
eq_(name, self.user.display_name)
class QueueTest(EditorTest):
fixtures = ['base/users']
def setUp(self):
super(QueueTest, self).setUp()
self.login_as_editor()
self.versions = {}
self.addon_file(u'Pending One', u'0.1',
amo.STATUS_PUBLIC, amo.STATUS_UNREVIEWED)
self.addon_file(u'Pending Two', u'0.1',
amo.STATUS_PUBLIC, amo.STATUS_UNREVIEWED)
self.addon_file(u'Nominated One', u'0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED)
self.addon_file(u'Nominated Two', u'0.1',
amo.STATUS_LITE_AND_NOMINATED, amo.STATUS_UNREVIEWED)
self.addon_file(u'Prelim One', u'0.1',
amo.STATUS_LITE, amo.STATUS_UNREVIEWED)
self.addon_file(u'Prelim Two', u'0.1',
amo.STATUS_UNREVIEWED, amo.STATUS_UNREVIEWED)
self.addon_file(u'Public', u'0.1',
amo.STATUS_PUBLIC, amo.STATUS_LISTED)
def addon_file(self, *args, **kw):
a = create_addon_file(*args, **kw)
self.versions[unicode(a['addon'].name)] = a['version']
class TestQueueBasics(QueueTest):
def test_only_viewable_by_editor(self):
self.client.logout()
assert self.client.login(username='regular@mozilla.com',
password='password')
r = self.client.get(reverse('editors.queue_pending'))
eq_(r.status_code, 403)
def test_invalid_page(self):
r = self.client.get(reverse('editors.queue_pending'),
data={'page': 999})
eq_(r.status_code, 200)
eq_(r.context['page'].number, 1)
def test_invalid_per_page(self):
r = self.client.get(reverse('editors.queue_pending'),
data={'per_page': '<garbage>'})
# No exceptions:
eq_(r.status_code, 200)
def test_redirect_to_review(self):
r = self.client.get(reverse('editors.queue_pending'), data={'num': 2})
self.assertRedirects(r,
reverse('editors.review',
args=[self.versions['Pending Two'].id]) + '?num=2')
def test_invalid_review_ignored(self):
r = self.client.get(reverse('editors.queue_pending'), data={'num': 9})
eq_(r.status_code, 200)
def test_garbage_review_num_ignored(self):
r = self.client.get(reverse('editors.queue_pending'),
data={'num': 'not-a-number'})
eq_(r.status_code, 200)
def test_grid_headers(self):
r = self.client.get(reverse('editors.queue_pending'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('table.data-grid tr th:eq(0)').text(), u'Addon')
eq_(doc('table.data-grid tr th:eq(1)').text(), u'Type')
eq_(doc('table.data-grid tr th:eq(2)').text(), u'Waiting Time')
eq_(doc('table.data-grid tr th:eq(3)').text(), u'Flags')
eq_(doc('table.data-grid tr th:eq(4)').text(), u'Applications')
eq_(doc('table.data-grid tr th:eq(5)').text(),
u'Additional Information')
def test_no_results(self):
File.objects.all().delete()
r = self.client.get(reverse('editors.queue_pending'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('.queue-outer .no-results').length, 1)
def test_no_paginator_when_on_single_page(self):
r = self.client.get(reverse('editors.queue_pending'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('.pagination').length, 0)
def test_paginator_when_many_pages(self):
q = File.objects.exclude(version__in=(self.versions['Nominated One'],
self.versions['Nominated Two']))
q.delete()
r = self.client.get(reverse('editors.queue_nominated'),
data={'per_page': 1})
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('.data-grid-top .num-results').text(),
u'Results 1 \u2013 1 of 2')
eq_(doc('.data-grid-bottom .num-results').text(),
u'Results 1 \u2013 1 of 2')
def test_navbar_queue_counts(self):
r = self.client.get(reverse('editors.home'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('#navbar li.top ul').eq(0).text(),
'Full Reviews (2) Pending Updates (2) '
'Preliminary Reviews (2) Moderated Reviews (0)')
def test_legacy_queue_sort(self):
sorts = (
['age', 'Waiting Time'],
['name', 'Addon'],
['type', 'Type'],
)
for key, text in sorts:
url = reverse('editors.queue_pending') + '?sort=%s' % key
response = self.client.get(url)
eq_(response.status_code, 200)
doc = pq(response.content)
eq_(doc('th.ordered a').text(), text)
def test_full_reviews_bar(self):
addon = Addon.objects.filter(status=amo.STATUS_LITE_AND_NOMINATED)[0]
review_data = ((1, (0, 0, 100), 2),
(8, (0, 50, 50), 1),
(11, (50, 0, 50), 1))
style = lambda w: "width:%s%%" % (float(w) if w > 0 else 0)
for (days, widths, under_7) in review_data:
new_nomination = datetime.now() - timedelta(days=days)
addon.versions.all()[0].update(nomination=new_nomination)
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
div = doc('#editors-stats-charts .editor-stats-table:eq(0)')
eq_(doc('.waiting_old', div).attr('style'), style(widths[0]))
eq_(doc('.waiting_med', div).attr('style'), style(widths[1]))
eq_(doc('.waiting_new', div).attr('style'), style(widths[2]))
assert "%s submi" % under_7 in doc('div>div:eq(0)', div).text()
def test_pending_bar(self):
review_data = ((1, (0, 0, 100), 2),
(8, (0, 50, 50), 1),
(11, (50, 0, 50), 1))
style = lambda w: "width:%s%%" % (float(w) if w > 0 else 0)
for (days, widths, under_7) in review_data:
addon = self.versions['Pending One'].addon
new_created = datetime.now() - timedelta(days=days)
version = addon.versions.all()[0]
version.modified = new_created
version.created = new_created
version.save()
# We have to re-set the status of the add-on after saving version
addon.update(status=amo.STATUS_PUBLIC)
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
div = doc('#editors-stats-charts .editor-stats-table:eq(1)')
eq_(doc('.waiting_old', div).attr('style'), style(widths[0]))
eq_(doc('.waiting_med', div).attr('style'), style(widths[1]))
eq_(doc('.waiting_new', div).attr('style'), style(widths[2]))
assert "%s submi" % under_7 in doc('div>div:eq(0)', div).text()
def test_prelim_bar(self):
review_data = ((1, (0, 0, 100), 2),
(8, (0, 50, 50), 1),
(11, (50, 0, 50), 1))
style = lambda w: "width:%s%%" % (float(w) if w > 0 else 0)
for (days, widths, under_7) in review_data:
addon = self.versions['Prelim One'].addon
new_created = datetime.now() - timedelta(days=days)
version = addon.versions.all()[0]
version.modified = new_created
version.created = new_created
version.save()
r = self.client.get(reverse('editors.home'))
doc = pq(r.content)
div = doc('#editors-stats-charts .editor-stats-table:eq(2)')
eq_(doc('.waiting_old', div).attr('style'), style(widths[0]))
eq_(doc('.waiting_med', div).attr('style'), style(widths[1]))
eq_(doc('.waiting_new', div).attr('style'), style(widths[2]))
assert "%s submi" % under_7 in doc('div>div:eq(0)', div).text()
class TestPendingQueue(QueueTest):
def test_results(self):
r = self.client.get(reverse('editors.queue_pending'))
eq_(r.status_code, 200)
doc = pq(r.content)
row = doc('table.data-grid tr:eq(1)')
eq_(doc('td:eq(0)', row).text(), u'Pending One 0.1')
eq_(doc('td a:eq(0)', row).attr('href'),
reverse('editors.review',
args=[self.versions[u'Pending One'].id]) + '?num=1')
row = doc('table.data-grid tr:eq(2)')
eq_(doc('td:eq(0)', row).text(), u'Pending Two 0.1')
eq_(doc('a:eq(0)', row).attr('href'),
reverse('editors.review',
args=[self.versions[u'Pending Two'].id]) + '?num=2')
def test_queue_count(self):
r = self.client.get(reverse('editors.queue_pending'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('.tabnav li a:eq(1)').text(), u'Pending Updates (2)')
eq_(doc('.tabnav li a:eq(1)').attr('href'),
reverse('editors.queue_pending'))
def test_breadcrumbs(self):
r = self.client.get(reverse('editors.queue_pending'))
doc = pq(r.content)
list_items = doc('ol.breadcrumbs li')
eq_(list_items.length, 2)
eq_(list_items.eq(0).find('a').text(), "Editor Tools")
eq_(list_items.eq(1).text(), "Pending Updates")
class TestNominatedQueue(QueueTest):
def test_results(self):
r = self.client.get(reverse('editors.queue_nominated'))
eq_(r.status_code, 200)
doc = pq(r.content)
row = doc('table.data-grid tr:eq(1)')
eq_(doc('td:eq(0)', row).text(), u'Nominated One 0.1')
eq_(doc('td a:eq(0)', row).attr('href'),
reverse('editors.review',
args=[self.versions[u'Nominated One'].id]) + '?num=1')
row = doc('table.data-grid tr:eq(2)')
eq_(doc('td:eq(0)', row).text(), u'Nominated Two 0.1')
eq_(doc('a:eq(0)', row).attr('href'),
reverse('editors.review',
args=[self.versions[u'Nominated Two'].id]) + '?num=2')
def test_results_two_versions(self):
ver = self.versions['Nominated Two'].addon.versions.all()[0]
file = ver.files.all()[0]
original_nomination = ver.nomination
ver.nomination = ver.nomination - timedelta(days=1)
ver.save()
ver.pk = None
ver.nomination = original_nomination
ver.version = "0.2"
ver.save()
file.pk = None
file.version = ver
file.save()
r = self.client.get(reverse('editors.queue_nominated'))
eq_(r.status_code, 200)
doc = pq(r.content)
row = doc('table.data-grid tr:eq(2)')
eq_(doc('td:eq(0)', row).text(), u'Nominated Two 0.2')
# Make sure the time isn't the same as the original time.
# (We're using the other row as a constant for comparison.)
row_constant = doc('table.data-grid tr:eq(1)')
eq_(doc('td:eq(2)', row).text(), doc('td:eq(2)', row_constant).text())
def test_queue_count(self):
r = self.client.get(reverse('editors.queue_nominated'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('.tabnav li a:eq(0)').text(), u'Full Reviews (2)')
eq_(doc('.tabnav li a:eq(0)').attr('href'),
reverse('editors.queue_nominated'))
class TestPreliminaryQueue(QueueTest):
def test_results(self):
r = self.client.get(reverse('editors.queue_prelim'))
eq_(r.status_code, 200)
doc = pq(r.content)
row = doc('table.data-grid tr:eq(1)')
eq_(doc('td:eq(0)', row).text(), u'Prelim One 0.1')
eq_(doc('td a:eq(0)', row).attr('href'),
reverse('editors.review',
args=[self.versions[u'Prelim One'].id]) + '?num=1')
row = doc('table.data-grid tr:eq(2)')
eq_(doc('td:eq(0)', row).text(), u'Prelim Two 0.1')
eq_(doc('a:eq(0)', row).attr('href'),
reverse('editors.review',
args=[self.versions[u'Prelim Two'].id]) + '?num=2')
def test_queue_count(self):
r = self.client.get(reverse('editors.queue_prelim'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('.tabnav li a:eq(2)').text(), u'Preliminary Reviews (2)')
eq_(doc('.tabnav li a:eq(2)').attr('href'),
reverse('editors.queue_prelim'))
def test_breadcrumbs(self):
r = self.client.get(reverse('editors.queue_prelim'))
doc = pq(r.content)
list_items = doc('ol.breadcrumbs li')
eq_(list_items.length, 2)
eq_(list_items.eq(0).find('a').text(), "Editor Tools")
eq_(list_items.eq(1).text(), "Preliminary Reviews")
class TestModeratedQueue(QueueTest):
fixtures = ['base/users', 'base/apps', 'reviews/dev-reply.json']
def setUp(self):
self.url = reverse('editors.queue_moderated')
url_flag = reverse('reviews.flag', args=['a1865', 218468])
self.login_as_editor()
response = self.client.post(url_flag, {'flag': ReviewFlag.SPAM})
eq_(response.status_code, 200)
eq_(ReviewFlag.objects.filter(flag=ReviewFlag.SPAM).count(), 1)
eq_(Review.objects.filter(editorreview=True).count(), 1)
def test_results(self):
r = self.client.get(reverse('editors.queue_moderated'))
eq_(r.status_code, 200)
doc = pq(r.content)
rows = doc('#reviews-flagged .review-flagged:not(.review-saved)')
eq_(len(rows), 1)
row = rows[0]
assert re.findall("Don't use Firefox", doc('h3', row).text())
# Default is "Skip"
assert doc('#id_form-0-action_1:checked')
def setup_actions(self, action):
ctx = self.client.get(self.url).context
fs = initial(ctx['reviews_formset'].forms[0])
eq_(len(Review.objects.filter(addon=1865)), 2)
data_formset = formset(fs)
data_formset['form-0-action'] = action
r = self.client.post(reverse('editors.queue_moderated'), data_formset)
eq_(r.status_code, 302)
def test_skip(self):
self.setup_actions(reviews.REVIEW_MODERATE_SKIP)
# Make sure it's still there.
r = self.client.get(reverse('editors.queue_moderated'))
doc = pq(r.content)
rows = doc('#reviews-flagged .review-flagged:not(.review-saved)')
eq_(len(rows), 1)
def test_remove(self):
""" Make sure the editor tools can delete a review. """
al = ActivityLog.objects.filter(action=amo.LOG.DELETE_REVIEW.id)
al_start = al.count()
self.setup_actions(reviews.REVIEW_MODERATE_DELETE)
# Make sure it's removed from the queue.
r = self.client.get(reverse('editors.queue_moderated'))
doc = pq(r.content)
rows = doc('#reviews-flagged .review-flagged:not(.review-saved)')
eq_(len(rows), 0)
r = self.client.get(reverse('editors.eventlog'))
doc = pq(r.content)
assert 'More details' in doc('table a').text()
# Make sure it was actually deleted.
eq_(len(Review.objects.filter(addon=1865)), 1)
# One activity logged.
al_end = ActivityLog.objects.filter(action=amo.LOG.DELETE_REVIEW.id)
eq_(al_start + 1, al_end.count())
def test_keep(self):
""" Make sure the editor tools can remove flags and keep a review. """
al = ActivityLog.objects.filter(action=amo.LOG.APPROVE_REVIEW.id)
al_start = al.count()
review = Review.objects.filter(addon=1865, editorreview=1)
eq_(len(review), 1)
self.setup_actions(reviews.REVIEW_MODERATE_KEEP)
# Make sure it's removed from the queue.
r = self.client.get(reverse('editors.queue_moderated'))
doc = pq(r.content)
rows = doc('#reviews-flagged .review-flagged:not(.review-saved)')
eq_(len(rows), 0)
review = Review.objects.filter(addon=1865)
# Make sure it's NOT deleted...
eq_(len(review), 2)
# ...but it's no longer flagged
eq_(len(review.filter(editorreview=1)), 0)
# One activity logged.
al_end = ActivityLog.objects.filter(action=amo.LOG.APPROVE_REVIEW.id)
eq_(al_start + 1, al_end.count())
def test_queue_count(self):
r = self.client.get(reverse('editors.queue_moderated'))
eq_(r.status_code, 200)
doc = pq(r.content)
eq_(doc('.tabnav li a:eq(3)').text(), u'Moderated Review (1)')
eq_(doc('.tabnav li a:eq(3)').attr('href'),
reverse('editors.queue_moderated'))
def test_breadcrumbs(self):
r = self.client.get(reverse('editors.queue_moderated'))
doc = pq(r.content)
list_items = doc('ol.breadcrumbs li')
eq_(list_items.length, 2)
eq_(list_items.eq(0).find('a').text(), "Editor Tools")
eq_(list_items.eq(1).text(), "Moderated Reviews")
def test_no_reviews(self):
Review.objects.all().delete()
eq_(Review.objects.exists(), False)
r = self.client.get(reverse('editors.queue_moderated'))
eq_(r.status_code, 200)
doc = pq(r.content)
message = 'All reviews have been moderated. Good work!'
eq_(doc('.no-results').text(), message)
eq_(doc('.review-saved button').length, 1) # Only show one button.
class TestPerformance(QueueTest):
fixtures = ('base/users', 'editors/pending-queue', 'base/approvals')
"""Test the page at /editors/performance."""
def setUp(self):
super(TestPerformance, self).setUp()
self.url_performance = reverse('editors.performance')
def test_performance_chart(self):
r = self.client.get(self.url_performance)
doc = pq(r.content)
data = {u'2010-08': {u'teamcount': 1, u'teamavg': u'1.0',
u'usercount': 1, u'teamamt': 1,
u'label': u'Aug 2010'}}
eq_(json.loads(doc('#monthly').attr('data-chart')), data)
class SearchTest(EditorTest):
def setUp(self):
self.login_as_editor()
def named_addons(self, request):
return [row.data.addon_name
for row in request.context['page'].object_list]
def search(self, data):
r = self.client.get(self.url, data=data)
eq_(r.status_code, 200)
eq_(r.context['search_form'].errors.as_text(), '')
return r
class TestQueueSearch(SearchTest):
fixtures = ('base/users', 'base/apps', 'base/appversion')
def setUp(self):
super(TestQueueSearch, self).setUp()
self.url = reverse('editors.queue_nominated')
create_addon_file('Not Admin Reviewed', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED)
create_addon_file('Admin Reviewed', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
admin_review=True)
create_addon_file('Justin Bieber Persona', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
addon_type=amo.ADDON_THEME)
create_addon_file('Justin Bieber Search Bar', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
addon_type=amo.ADDON_SEARCH)
create_addon_file('Bieber For Mobile', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
application=amo.MOBILE)
create_addon_file('Linux Widget', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
platform=amo.PLATFORM_LINUX)
create_addon_file('Mac Widget', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
platform=amo.PLATFORM_MAC)
def test_search_by_admin_reviewed(self):
r = self.search({'admin_review': 1})
eq_(self.named_addons(r), ['Admin Reviewed'])
def test_queue_counts(self):
r = self.search({'text_query': 'admin', 'per_page': 1})
doc = pq(r.content)
eq_(doc('.data-grid-top .num-results').text(),
u'Results 1 \u2013 1 of 2')
def test_search_by_addon_name(self):
r = self.search({'text_query': 'admin'})
eq_(sorted(self.named_addons(r)), ['Admin Reviewed',
'Not Admin Reviewed'])
def test_search_by_addon_in_locale(self):
uni = 'フォクすけといっしょ'.decode('utf8')
d = create_addon_file('Some Addon', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED)
a = Addon.objects.get(pk=d['addon'].id)
a.name = {'ja': uni}
a.save()
r = self.client.get('/ja/' + self.url, data={'text_query': uni},
follow=True)
eq_(r.status_code, 200)
eq_(sorted(self.named_addons(r)), ['Some Addon'])
def test_search_by_addon_author(self):
d = create_addon_file('For Author Search', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED)
u = UserProfile.objects.create(username='fligtar',
email='Fligtar@fligtar.com')
au = AddonUser.objects.create(user=u, addon=d['addon'])
author = AddonUser.objects.filter(id=au.id)
for role in [amo.AUTHOR_ROLE_OWNER,
amo.AUTHOR_ROLE_DEV]:
author.update(role=role)
r = self.search({'text_query': 'fligtar@fligtar.com'})
eq_(self.named_addons(r), ['For Author Search'])
author.update(role=amo.AUTHOR_ROLE_VIEWER)
r = self.search({'text_query': 'fligtar@fligtar.com'})
eq_(self.named_addons(r), [])
def test_search_by_supported_email_in_locale(self):
d = create_addon_file('Some Addon', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED)
uni = 'フォクすけといっしょ@site.co.jp'.decode('utf8')
a = Addon.objects.get(pk=d['addon'].id)
a.support_email = {'ja': uni}
a.save()
r = self.client.get('/ja/' + self.url, data={'text_query': uni},
follow=True)
eq_(r.status_code, 200)
eq_(sorted(self.named_addons(r)), ['Some Addon'])
def test_search_by_addon_type(self):
r = self.search({'addon_type_ids': [amo.ADDON_THEME]})
eq_(self.named_addons(r), ['Justin Bieber Persona'])
def test_search_by_addon_type_any(self):
r = self.search({'addon_type_ids': [amo.ADDON_ANY]})
assert len(self.named_addons(r)) > 0
def test_search_by_many_addon_types(self):
r = self.search({'addon_type_ids': [amo.ADDON_THEME,
amo.ADDON_SEARCH]})
eq_(sorted(self.named_addons(r)),
['Justin Bieber Persona', 'Justin Bieber Search Bar'])
def test_search_by_platform_mac(self):
r = self.search({'platform_ids': [amo.PLATFORM_MAC.id]})
eq_(r.status_code, 200)
eq_(self.named_addons(r), ['Mac Widget'])
def test_search_by_platform_linux(self):
r = self.search({'platform_ids': [amo.PLATFORM_LINUX.id]})
eq_(r.status_code, 200)
eq_(self.named_addons(r), ['Linux Widget'])
def test_search_by_platform_mac_linux(self):
r = self.search({'platform_ids': [amo.PLATFORM_MAC.id,
amo.PLATFORM_LINUX.id]})
eq_(r.status_code, 200)
eq_(sorted(self.named_addons(r)), ['Linux Widget', 'Mac Widget'])
def test_preserve_multi_platform_files(self):
for plat in (amo.PLATFORM_WIN, amo.PLATFORM_MAC):
create_addon_file('Multi Platform', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
platform=plat)
r = self.search({'platform_ids': [amo.PLATFORM_WIN.id]})
doc = pq(r.content)
# Should not say Windows only:
eq_(doc('table.data-grid tr').eq(1).children('td').eq(5).text(), '')
def test_preserve_single_platform_files(self):
create_addon_file('Windows', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
platform=amo.PLATFORM_WIN)
r = self.search({'platform_ids': [amo.PLATFORM_WIN.id]})
doc = pq(r.content)
eq_(doc('table.data-grid tr').eq(1).children('td').eq(5).text(),
'Windows only')
def test_search_by_app(self):
r = self.search({'application_id': [amo.MOBILE.id]})
eq_(r.status_code, 200)
eq_(self.named_addons(r), ['Bieber For Mobile'])
def test_search_by_version_requires_app(self):
r = self.client.get(self.url, data={'max_version': '3.6'})
eq_(r.status_code, 200)
# This is not the most descriptive message but it's
# the easiest to show. This missing app scenario is unlikely.
eq_(r.context['search_form'].errors.as_text(),
'* max_version\n * Select a valid choice. 3.6 is not '
'one of the available choices.')
def test_search_by_app_version(self):
d = create_addon_file('Bieber For Mobile 4.0b2pre', '0.1',
amo.STATUS_NOMINATED, amo.STATUS_UNREVIEWED,
application=amo.MOBILE)
app = Application.objects.get(pk=amo.MOBILE.id)
max = AppVersion.objects.get(application=app, version='4.0b2pre')
VersionSummary.objects.create(application=app,
version=d['version'],
addon=d['addon'],
max=max.id)
r = self.search({'application_id': amo.MOBILE.id,
'max_version': '4.0b2pre'})
eq_(self.named_addons(r), [u'Bieber For Mobile 4.0b2pre'])
def test_age_of_submission(self):
Version.objects.update(nomination=datetime.now() - timedelta(days=1))
title = 'Justin Bieber Persona'
bieber = (Version.objects.filter(addon__name__localized_string=title))
# Exclude anything out of range:
bieber.update(nomination=datetime.now() - timedelta(days=5))
r = self.search({'waiting_time_days': 2})
addons = self.named_addons(r)
assert title not in addons, ('Unexpected results: %r' % addons)
# Include anything submitted up to requested days:
bieber.update(nomination=datetime.now() - timedelta(days=2))
r = self.search({'waiting_time_days': 5})
addons = self.named_addons(r)
assert title in addons, ('Unexpected results: %r' % addons)
# Special case: exclude anything under 10 days:
bieber.update(nomination=datetime.now() - timedelta(days=8))
r = self.search({'waiting_time_days': '10+'})
addons = self.named_addons(r)
assert title not in addons, ('Unexpected results: %r' % addons)
# Special case: include anything 10 days and over:
bieber.update(nomination=datetime.now() - timedelta(days=12))
r = self.search({'waiting_time_days': '10+'})
addons = self.named_addons(r)
assert title in addons, ('Unexpected results: %r' % addons)
def test_form(self):
r = self.search({})
doc = pq(r.content)
eq_(doc('#id_application_id').attr('data-url'),
reverse('editors.application_versions_json'))
eq_(doc('#id_max_version option').text(),
'Select an application first')
r = self.search({'application_id': amo.MOBILE.id})
doc = pq(r.content)
eq_(doc('#id_max_version option').text(), '4.0b2pre 2.0a1pre 1.0')
def test_application_versions_json(self):
r = self.client.post(reverse('editors.application_versions_json'),
{'application_id': amo.MOBILE.id})
eq_(r.status_code, 200)
data = json.loads(r.content)
eq_(data['choices'],
[['', ''],
['4.0b2pre', '4.0b2pre'],
['2.0a1pre', '2.0a1pre'],
['1.0', '1.0']])