Bug 622883, l10n refactor AND new tests!

jbalogh · Jan 7, 2011 · 026ab34 · 026ab34
1 parent c2ac36e
commit 026ab34
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/media/js/zamboni/l10n.js b/media/js/zamboni/l10n.js
@@ -179,15 +179,20 @@ $(document).ready(function () {
                 field = $el.attr('data-name'),
                 label = $(format("label[data-for={0}]",[field]));
             if (!$el.find(format("[lang={0}]",[lang])).length) {
-                var $ni = $el.children(".init-trans").clone();
-                $ni.attr({
-                    class: "cloned",
-                    lang: lang,
-                });
-                if ($ni.is(':not(span)')) {
+                if ($el.children(".trans-init").length) {
+                    var $ni = $el.children(".trans-init").clone();
                     $ni.attr({
+                        'class': "cloned",
+                        lang: lang,
                         id: format('id_{0}_{1}', field, lang),
-                        name: [field,lang].join('_')
+                        name: [field,lang].join('_'),
+                        value: $el.find(format("[lang={0}]",[dl])).val()
+                    });
+                } else {
+                    var $ni = $el.find(format("[lang={0}]",dl)).clone();
+                    $ni.attr({
+                        'class': "cloned",
+                        lang: lang
                     });
                 }
                 $el.append($ni);

diff --git a/media/js/zamboni/tests/l10n_tests.js b/media/js/zamboni/tests/l10n_tests.js
@@ -18,11 +18,20 @@ test('English', function() {
            'development tools...');
 });
 
-test('Japanese', function() {
+test('Japanese (existing translation)', function() {
     z.refreshL10n('ja');
     equals($('textarea:visible', this.sandbox).text().trim(),
            'Firebug は、Web ページを閲覧中にクリック一つで使える豊富な開発ツールを Firefox' +
            ' に統合します。あなたはあらゆる');
 });
 
+test('Afrikaans (new translation)', function() {
+    z.refreshL10n('af');
+    equals($('[lang=af]', this.sandbox).length, 1);
+    equals($('textarea:visible', this.sandbox).text().trim(),
+           'Firebug integrates with Firefox to put a wealth of ' +
+           'development tools...');
+    equals($('textarea:visible', this.sandbox).hasClass('cloned'), true);
+});
+
 });