check for current_version updates every minute (bug 583122)

jbalogh · Jul 30, 2010 · 17698c6 · 17698c6
1 parent a1e2c2c
commit 17698c6
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 6 deletions.
diff --git a/apps/addons/cron.py b/apps/addons/cron.py
@@ -1,3 +1,5 @@
+from datetime import datetime, timedelta
+
 from django.db import connection, connections, transaction
 from django.db.models import Max, Q, F
 
@@ -16,6 +18,18 @@
 task_log = commonware.log.getLogger('z.task')
 
 
+@cronjobs.register
+def fast_current_version():
+    # Only find the really recent versions; this is called a lot.
+    t = datetime.now() - timedelta(minutes=5)
+    q = Addon.objects.filter(
+        Q(status=amo.STATUS_PUBLIC,
+          versions__files__datestatuschanged__gte=t) |
+        Q(status__in=amo.UNREVIEWED_STATUSES,
+          versions__files__created__gte=t))
+    _update_addons_current_version(q.values_list('id'))
+
+
 #TODO(davedash): This will not be needed as a cron task after remora.
 @cronjobs.register
 def update_addons_current_version():

diff --git a/scripts/crontab/make-crons.py b/scripts/crontab/make-crons.py
@@ -39,8 +39,11 @@
 
 HOME = /tmp
 
-# Every 20 minutes!
-*/20 * * * * $Z_CRON update_addons_current_version
+# Every minute!
+* * * * * $Z_CRON fast_current_version
+
+# Every 30 minutes.
+*/30 * * * * $Z_CRON update_addons_current_version
 
 #once per hour
 5 * * * * $Z_CRON update_collections_subscribers

diff --git a/scripts/crontab/preview b/scripts/crontab/preview
@@ -6,8 +6,11 @@ MAILTO=amo-developers@mozilla.org
 
 HOME = /tmp
 
-# Every 20 minutes!
-*/20 * * * * cd /data/amo_python/src/preview/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron update_addons_current_version
+# Every minute!
+* * * * * cd /data/amo_python/src/preview/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron fast_current_version
+
+# Every 30 minutes.
+*/30 * * * * cd /data/amo_python/src/preview/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron update_addons_current_version
 
 #once per hour
 5 * * * * cd /data/amo_python/src/preview/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron update_collections_subscribers

diff --git a/scripts/crontab/prod b/scripts/crontab/prod
@@ -6,8 +6,11 @@ MAILTO=amo-developers@mozilla.org
 
 HOME = /tmp
 
-# Every 20 minutes!
-*/20 * * * * apache cd /data/amo_python/src/prod/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron update_addons_current_version
+# Every minute!
+* * * * * apache cd /data/amo_python/src/prod/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron fast_current_version
+
+# Every 30 minutes.
+*/30 * * * * apache cd /data/amo_python/src/prod/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron update_addons_current_version
 
 #once per hour
 5 * * * * apache cd /data/amo_python/src/prod/zamboni; /data/virtualenvs/zamboni/bin/python manage.py cron update_collections_subscribers