Image upload was overzealous: 2047 requests per second per image.

It was polling for each image once every 100 milliseconds, and had a loop within a loop which doubled the amount of requests each time.
jbalogh · Feb 19, 2011 · 4e01b69 · 4e01b69
1 parent 7af7a6c
commit 4e01b69
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/media/js/zamboni/devhub.js b/media/js/zamboni/devhub.js
@@ -1332,7 +1332,7 @@ function initCompatibility() {
 function imagePoller() {
     this.start = function(override, delay) {
         if (override || !this.poll) {
-            this.poll = window.setTimeout(this.check, delay || 100);
+            this.poll = window.setTimeout(this.check, delay || 1000);
         }
     };
     this.stop = function() {
@@ -1364,8 +1364,11 @@ var imageStatus = {
         };
         this.preview.check = function() {
             var self = imageStatus;
-            $('div.preview-thumb').each(function(e) {
-                var $this = $(this);
+            $('div.preview-thumb').each(function(){
+                check_images(this);
+            });
+            function check_images(el) {
+                var $this = $(el);
                 if ($this.hasClass('preview-successful')) {
                     return;
                 }
@@ -1379,12 +1382,13 @@ var imageStatus = {
                     }
                 };
                 img.onerror = function() {
-                    self.preview.start(true, 2500);
+                    setTimeout(function(){ check_images(el) }, 2500);
                     self.polling();
                     $this.attr('style', '').addClass('preview-error');
+                    delete img;
                 };
                 img.src = self.newurl($this.attr('data-url'));
-            });
+            }
         };
         this.icon.start();
         this.preview.start();