Bug 597494, fixed JS error in tooltips for personas

jbalogh · Sep 17, 2010 · 7a5dfde · 7a5dfde
1 parent 4d52175
commit 7a5dfde
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/apps/addons/templates/addons/personas_detail.html b/apps/addons/templates/addons/personas_detail.html
@@ -68,8 +68,10 @@ <h4 class="author">{{ _('by') }} {{ users_list(addon.listed_authors) }}</h4>
           {{ big_install_button(addon, show_warning=False) }}
 
           {% if settings.NEW_COLLECTIONS %}
+          <div class="widgets">
             {{ favorites_widget(addon) }}
             {% include 'addons/includes/collection_add_widget.html' %}
+          </div>
           {% endif %}
 
           {# TODO(davedash): Remove until zamboni does sharing

diff --git a/media/css/zamboni/zamboni.css b/media/css/zamboni/zamboni.css
@@ -2893,13 +2893,8 @@ a.outlink:hover {
     width: 16px;
 }
 .html-rtl .widget.condensed {
-    margin-right: 0;
     margin-left: .8em;
 }
-.widgets .edit {
-    margin-left: .5em;
-    background-position: 0 -350px;
-}
 #addon .widgets {
     clear:left;
 }
@@ -2909,7 +2904,7 @@ a.outlink:hover {
     float: left;
 }
 .html-rtl #addon .widget { float: right; }
-.widget.edit:hover { background-position: 0 -300px; }
+.widget.edit { background-position: 0 -350px; }
 .widget.edit:hover { background-position: 0 -300px; }
 .widget.copy { background-position: 0 -50px; }
 .widget.copy:hover { background-position: 0 0px; }

diff --git a/media/js/zamboni/collections.js b/media/js/zamboni/collections.js
@@ -778,7 +778,7 @@ $(document).ready(function () {
                                 $(".share-networks", $popup).show();
                                 $(".share-email", $popup).hide();
                                 $(".share-email-success", $popup).hide();
-                                obj.hider();
+                                $popup.hideMe();
                             }, 800);
                         } else {
                             $(".share-email-success", $popup).hide();

diff --git a/media/js/zamboni/global.js b/media/js/zamboni/global.js
@@ -16,6 +16,7 @@ jQuery.fn.tooltip = function(tip_el) {
         $tgt, $title;
 
     function setTip() {
+        if (!$tgt) return;
         var pos = $tgt.offset();
 
         $msg.text($title.attr("title"));