Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oAuth logins #185

Open
jonphipps opened this issue Apr 26, 2013 · 3 comments
Open

oAuth logins #185

jonphipps opened this issue Apr 26, 2013 · 3 comments
Milestone

Comments

@jonphipps
Copy link
Contributor

I need to have github, bitbucket, and perhaps dropbox login/linkage capability, in addition to Google, Facebook and Twitter. Should I be considering a 3rd-party composer class like https://github.com/opauth/opauth (which looks good, has lots of framework integrations, but feels unstable) or something that would be bundled like PHP OAuth API (which actually looks quite nice)? Or should I just copy the Facebook provider and cobble something together for each? Not sure what would fit best with your general dev philosophy.

@jbroadway
Copy link
Owner

It would be good to move to using a 3rd party library like Opauth (HybridAuth is another to consider), instead of maintaining our own implementation for each provider, plus the support for all those extra providers for next to free. We'll still need a bit of glue code but probably less than what we've already got.

@jonphipps
Copy link
Contributor Author

The only problem I saw with HybridAuth was that it always returns a
standardized user profile across all social logins. When I was building an
exclusively GitHub-centric app a few months ago this was a bug more than a
feature, since the github-populated profile was a bit sparse and I needed
to go get the profile myself anyway. But that's probably a distinct
advantage for Elefant. I've spent time with oauth and HybridAuth but right
now php-oauth-api at phpclasses looks pretty compelling. The author has
some very good reasons for not wanting to distribute via composer:
http://www.phpclasses.org/discuss/package/7700/thread/64/ and it might be
an easy-to-update included library.

If I implement one of these, do you have a preference? I wouldn't want to
go in a direction that you're not comfortable with.

On Saturday, April 27, 2013, Johnny Broadway wrote:

It would be good to move to using a 3rd party library like Opauth (
HybridAuth http://hybridauth.sourceforge.net/ is another to consider),
instead of maintaining our own implementation for each provider, plus the
support for all those extra providers for next to free. We'll still need a
bit of glue code but probably less than what we've already got.


Reply to this email directly or view it on GitHubhttps://github.com//issues/185#issuecomment-17118006
.

Jon

@jbroadway
Copy link
Owner

I'm open to whichever you think is best suited. Just looked and they're all license-compatible too :)

@lux lux modified the milestones: 2.2, 2.4 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants