Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalisation of packing style DiamondsPlus #38

Closed
jdaw1 opened this issue Feb 20, 2021 · 0 comments
Closed

Generalisation of packing style DiamondsPlus #38

jdaw1 opened this issue Feb 20, 2021 · 0 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@jdaw1
Copy link
Owner

jdaw1 commented Feb 20, 2021

The packing style DiamondsPlus could be more general. It assumes Three rows or columns (/Landscape or /Portrait), whereas this could be generalised to allow more.

However, likely as not, this doesn’t matter. Realistic use cases are for not more than twenty-something glasses. Maybe, and maybe not, a generalisation would give a slightly larger radius for 41 glasses. But for n ≤ 25, the current DiamondsPlus seems to be sufficiently general.

@jdaw1 jdaw1 added the enhancement New feature or request label Feb 20, 2021
@jdaw1 jdaw1 added the wontfix This will not be worked on label Jun 10, 2021
@jdaw1 jdaw1 closed this as completed Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant