Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change header separator color to Outlook default #108

Open
cnmicha opened this issue May 11, 2021 · 8 comments
Open

Change header separator color to Outlook default #108

cnmicha opened this issue May 11, 2021 · 8 comments

Comments

@cnmicha
Copy link

cnmicha commented May 11, 2021

Hi,

how do you think about changing the default value of the preference extensions.replywithheader.header.separator.line.color to #1E1E1E which is the header separator line color of Outlook?

What was the idea behind choosing the current default color (#B5C4DF)?

If you like, I can provide a pull request for this.

Thanks!

@jeevatkm
Copy link
Owner

@cnmicha When initially developed the RWH add-on that time I took a color code from Outlook. I think the Outlook client still uses that color. I can see with my macOS Outlook client v16.52 (21080801).

May I know where do you see a black color? web version?

@anttiisoaho
Copy link

anttiisoaho commented Oct 11, 2023

Looks like Outlook has different default styles in Windows vs Mac. While css is used in email sent by O365 Outlook, I simplified styling into html tags without css and ended up with below html snippet. I had 24 hour clock but otherwise regular US English settings. Note how separator line is produced by O365 Outlook client in Windows, with line color E1E1E1. Below snippet is 100% similar than how replying or forwarding with O365 Outlook client in Windows.

<div><div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p style="margin-top:0;font-family:Calibri,sans-serif;font-size:11pt;">
<b>From:</b> Displayname_if_exist &lt;name@email.com&gt;<br>
<b>Sent:</b> Wednesday, October 11, 2023 17:32<br>
<b>To:</b> Displayname_if_exist &lt;name@email.com&gt;<br>
<b>Subject:</b> Email subject line</p>
</div></div>

@jeevatkm
Copy link
Owner

@anttiisoaho Thanks for providing the HTML string; it is helpful for understanding.

@cnmicha @anttiisoaho I will change the header line default color to #1E1E1E on v3.0.0 onwards; until then, please use the RWH add-on options to change the color.

@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Oct 12, 2023
@anttiisoaho
Copy link

@jeevatkm just note the corrrect color value: #E1E1E1 - I believe there was originally typo by @cnmicha. Additional notes:

  • HTML snippet above is exactly what O365 Outlook client in Windows use for separator+headers, with note that I simplified headers text style from css into <p> tag
  • From/To/Cc email addresses are inside < > and not inside [ ]

@jeevatkm
Copy link
Owner

@anttiisoaho Thanks. I will take care of it.

@jeevatkm jeevatkm removed the v3.0.0 label Oct 14, 2023
@jeevatkm jeevatkm modified the milestones: v3.0.0 Milestone, v2.7.0 Oct 14, 2023
@jeevatkm jeevatkm modified the milestones: v2.7.0, v3.0.0 Milestone Apr 30, 2024
@jeevatkm
Copy link
Owner

@cnmicha @anttiisoaho I'm working on the WebExtension version of RWH. The branch is here.

I require a sample string of the following in multiple languages for a Plain Text email.

Reply

On 4/27/24 5:58 PM, Thunderbird Add-ons wrote:

Forward

-------- Forwarded Message --------
Subject: Mozilla Add-on User Rating: ReplyWithHeader
Date: Sun, 28 Apr 2024 00:58:03 -0000
From: Thunderbird Add-ons <nobody@thunderbird.net>
To: jeeva@myjeeva.com

@anttiisoaho
Copy link

Plain text example from O365 (US English) if this is what you wanted - there is no difference in reply or forward so this applies to both:

-empty line, cursor blinks here when starting to reply or forward-
-empty line-
-----Original Message-----
From: Displayname_if_exist <name@email.com>
Sent: Tuesday, April 9, 2024 2:08 PM
To: Displayname_if_exist <name@email.com>
Subject: Email subject line
-empty line-
-forwarded or replied email content-

@jeevatkm
Copy link
Owner

jeevatkm commented May 1, 2024

Thanks, @anttiisoaho, for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants