Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellcheck as you type not working #142

Open
ahmedhselim opened this issue Oct 16, 2023 · 7 comments
Open

Spellcheck as you type not working #142

ahmedhselim opened this issue Oct 16, 2023 · 7 comments
Assignees
Labels

Comments

@ahmedhselim
Copy link

Hi,
When I reply or forward, the Spellcheck is not working although it is active. When I remove your add-on, it works fine.

@IgitBuh
Copy link

IgitBuh commented Nov 6, 2023

I can confirm this. The problem seems to be that an empty line is missing at the beginning. So the written text is being treated as a part of the signature and therefore is not included in the spell checking.

Without this addon, the empty line is present and it works fine.

The same reason also leads to the problem, that if a different signature is selected through the drop-down menu, the email text disappears as part of the replaced signature.

@jeevatkm This is a serious bug, could you please fix this as a priority?

@IgitBuh
Copy link

IgitBuh commented Nov 7, 2023

v2.7.0-beta solves this problem. Until the fix is officially available, it can be downloaded and installed manually, see #134.

@willemb2
Copy link

willemb2 commented Mar 6, 2024

I can confirm that v2.7.0-beta solves the issue of 'spellcheck as you type' not working on reply and forward.

@jeevatkm
Copy link
Owner

@willemb2 @IgitBuh @ahmedhselim Thanks for reaching out. I'm starting to work on the WebExtension version of RWH. I believe this issue will be sorted out with that.

@jeevatkm jeevatkm self-assigned this Mar 12, 2024
@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Apr 30, 2024
@jeevatkm
Copy link
Owner

@willemb2 @IgitBuh @ahmedhselim I'm working on the WebExtension version of RWH. The branch is here.

I require a sample string of the following in multiple languages for a Plain Text email.

Reply

On 4/27/24 5:58 PM, Thunderbird Add-ons wrote:

Forward

-------- Forwarded Message --------
Subject: Mozilla Add-on User Rating: ReplyWithHeader
Date: Sun, 28 Apr 2024 00:58:03 -0000
From: Thunderbird Add-ons <nobody@thunderbird.net>
To: jeeva@myjeeva.com

@IgitBuh
Copy link

IgitBuh commented Apr 30, 2024

Would you like a custom translation as close as possible to your sample or do you want us to copy some official translation from somewhere?

Here's a custom translation for German:

Antworten

Am 27.04.24 um 17:58 schrieb Thunderbird Add-ons:

Weiterleiten

-------- Weitergeleitete Nachricht --------
Betreff: Mozilla Add-on User Rating: ReplyWithHeader
Datum: Son, 28 Apr 2024 00:58:03 -0000
Von: Thunderbird Add-ons <nobody@thunderbird.net>
An: jeeva@myjeeva.com

What languages do you need? I just checked for the output of ChatGPT and it was perfect for German. If it helps, I could provide such a translation for other languages as well, to speed up the process for you.

@jeevatkm
Copy link
Owner

jeevatkm commented May 1, 2024

Thanks, @IgitBuh, for your help. In the latest Thunderbird with WebExtension, processing Plain Text emails requires string manipulation and processing. For example, schrieb is a keyword used to process the Reply/Reply All.

I'm looking for a word from the Thunderbird, so google or chatGPT will not help here. I'm currently in the processing of figuring out the way to collect keyword for languages supported by RWH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants