Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Testing onboardme on WSL for Windows. #106

Open
jessebot opened this issue Nov 27, 2022 · 6 comments
Open

Start Testing onboardme on WSL for Windows. #106

jessebot opened this issue Nov 27, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request 🚧 larger project this means a project is large and will take a while

Comments

@jessebot
Copy link
Owner

I rarely use Windows these days, as I'm getting more into gaming on Linux, but sometimes I have to use windows for a specific client I'm supporting. It would be good to see how onboardme runs on WSL, as it's not been tested there, and it would be awesome to say we support three major platforms. We won't be supporting windows directly, but the linux backend, we can certainly try to support :)

@Mahadsid, since you've been doing the work here to start testing out the documentation on WSL, this can be your ticket to communicate that on. So, if you find any other documentation bugs, or you find errors when trying to run onboardme, you can talk about them here, and if we need to, we can open other issues that link back to this on.

@jessebot jessebot added the enhancement New feature or request label Nov 27, 2022
@jessebot
Copy link
Owner Author

Great, whenever you're ready, start with seeing if you can install onboardme on a WSL backend, preferably a Debian based backend, so we can we make sure we're fairly compatible. The first step will be making sure you can install the package, and then making sure you can run --help, which is a beginning test. If you can get that far, you can officially start development on helping with Windows deployments.

When you get there, open a ticket to update the docs to say that windows support is in alpha. Then create a pull request with the doc fix, (this can go in the status section of the readme), and take a look at pyproject.toml and see about modifying the classifiers. The classifier you'll want to add is the version of windows you're testing on, and you can find that syntax here. Finally, the bit that's more fun, the python 🐍 🎉 : you'll want to modify the check_os_support function to handle windows (or whatever it is that the uname command returns for WSL) as a supported OS, which is located here: https://github.com/jessebot/onboardme/blob/main/onboardme/env_config.py#L45

You can then link that ticket back here by posting the link in a comment on this issue. :)

@jessebot
Copy link
Owner Author

Btw, when you're ready for a review on things, or if you have questions or need any help, feel free to tag myself or @cloudymax.

@jessebot
Copy link
Owner Author

@Mahadsid quick check in, are you still interested in working on this? I can otherwise close the ticket, and just reopen it when I have time to actually work on it. If you're planning on getting to this, but busy with other things in your life, feel free to just let me know you intend to get to it at a later date. I'll periodically check in once a month or so to verify the status of this, unless I get all the other tickets done, then I'll begin work on this, but will still ping you if you'd like to pair program. 🙏

@jessebot jessebot added the 🚧 larger project this means a project is large and will take a while label Dec 19, 2022
@jessebot
Copy link
Owner Author

Sounds good and will do! Good luck on your finals! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🚧 larger project this means a project is large and will take a while
Projects
None yet
Development

No branches or pull requests

2 participants
@jessebot and others