-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the unspecified behavior that happens when you add attributes to …
…list items.
- Loading branch information
Showing
2 changed files
with
32 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28f97a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, RedCloth folks. The other day, I tried this:
thinking I’d get this:
But that’s not how it works. RedCloth 3 & 4 and Textile 2 both make the class/id you put on the first item in the list the class/id for the whole list. When you put classes/ids on subsequent list items, RedCloth 3 blows up, Textile2 makes them completely separate lists, and RedCloth 4 puts classes on the wrong list items (I’m fixing that now).
Here’s what PyTextile does:
To style a list, the parameters should go before the hash if you want to set the attributes on the
<ol>
tag:If you want to customize the first
<li>
tag, apply the parameters after the hash:What do you think? Stick close to Textile 2 or go out on our own to expand Textile’s breadth of expression? Is there a way to be able to specify list-item attributes and be backwards compatible?