Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility's xl_parse_time enhancement/fix #11

Closed
ghost opened this issue Jul 4, 2012 · 0 comments
Closed

Utility's xl_parse_time enhancement/fix #11

ghost opened this issue Jul 4, 2012 · 0 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Jul 4, 2012

File Excel/Writer/XLSX/Utility.pm

And my second suggestion is to skip the \d{1,2} check, so the line 286 would look like this

From

$time =~ /(\d{1,2}):(\d\d):?((?:\d\d)(?:.\d+)?)?(?:\s+)?(am|pm)?/i

to
$time =~ /(\d+):(\d\d):?((?:\d\d)(?:.\d+)?)?(?:\s+)?(am|pm)?/i

My reason is simple, I have to deal with time intervals. If you want to measure for example person's internet usage in month, it could be certainly larger than 99 hours, so why to stop with \d{1,2} for hours?

@ghost ghost assigned jmcnamara Sep 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant