New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hanging Culerity driver #99
Comments
I'm very confused as to what's going on here and where exactly the problem lies :S |
Apparently, the root problem is this bug in HtmlUnit. As you know, Celerity is a wrapper for HtmlUnit and it comes with a bundled snapshot of the HtmlUnit jars, which means that in a recent update to Celerity, when the latest HtmlUnit was pulled in from upstream, the bug started to manifest itself. I see it in my RSpec/Steak/Capybara/Culerity/Celerity workflow as spec runs which complete successfully (0 failures) but never actually fully exit because the JVM just sits hanging, waiting for something... The workaround is to call All I know is that if I change this in Capybara's Culerity driver from:
To:
Then the hanging goes away. It seems a workaround of some kind needs to go in somewhere, because the HtmlUnit team seems pretty slow to respond on this issue (look at the date on that issue tracker ticket linked above, and the lack of response). I don't know. Do you think this extra |
Does this break when used with the current stable version of celerity? If it doesn't, then there's no harm in adding that extra call, imho. |
Let me just check now... |
Ok, just rolled back from Celerity 0.8.0.beta.1 to Celerity 0.7.9 and it seems that the extra |
Pushed it here in case you want it: http://github.com/wincent/capybara/commits/hanging-culerity-fix |
This was pushed a long time ago, but I seem to have forgot to close this issue. |
Just noticed this hanging issue with the new Celerity prerelease (the 0.8.0 beta):
http://github.com/jarib/celerity/issues/#issue/23
The workaround is apparently to add
@_browser.close
in theat_exit
handler for the Culerity driver.Do you think we should apply this to Capybara now? Or wait for an upstream fix? (No comments on the HtmlUnit ticket, so not even sure if they consider it a bug or not.)
Cheers,
Wincent
The text was updated successfully, but these errors were encountered: