-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attachment support #7
Comments
+1 for this feature |
I probably won't come around to do this in the next two weeks due to my holiday, so don't hold your breath ;-). |
I've read through the new API docs and it seems that adding attachments requires you to use the SendRawEmail endpoint instead of the (easier) SendEmail endpoint this library is currently using. Switching would require quite some rewriting, since this resources requires you to write all the headers yourself, but allows for more features in the future (like DKIM signing). Watch this space. |
I developed this feature the last week in the job, i will create a branch to upload it and share it |
Sounds great Francisco. Using the SendRawEmail endpoint, I presume? |
Yes, I will use a SendRawEmail endpoint if you send and email with attachment but if you dont have attachment in the email i will use a SendEmail endpoint. |
Cool. Looking forward to your pull request. On Nov 28, 2012, at 9:16 AM, Francisco Javier Arias notifications@github.com wrote:
|
For it works i needed to change the _format_query_raw_string to this. private function _format_query_raw_string()
|
Amazon just announced support for attachment.
The text was updated successfully, but these errors were encountered: