Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selectively disable popups #189

Closed
joewing opened this issue Jul 4, 2015 · 1 comment
Closed

Selectively disable popups #189

joewing opened this issue Jul 4, 2015 · 1 comment
Labels
enhancement
Milestone
Version 2.3.2

Comments

@joewing
Copy link
Owner

joewing commented Jul 4, 2015

Currently JWM allows one to enable or disable all popups. It would be nice to be able to disable popups on the taskbar and not on the clock, for example. Current places where JWM displays a popup where it should be configurable:

  • Tray buttons (this can be disabled on a per-button basis using popup="").
  • Task list items
  • Clocks
  • Pagers

My proposal is to make the PopupStyle "enabled" attribute support a comma separated list of the following:

  • true (enabled for everything, the default)
  • false (disabled for everything)
  • task (enabled for task lists)
  • pager (enabled for pagers)
  • button (enabled for tray buttons)
  • clock (enabled for clocks)
joewing added a commit that referenced this issue Jul 29, 2015
@joewing
Make it possible to selectively enable popups (issue #189).
812240f
@joewing joewing added this to the Version 2.3.2 milestone Jul 29, 2015
@joewing
Copy link
Owner Author

joewing commented Jul 29, 2015

Fixed in snapshot 1198.

@joewing joewing closed this as completed Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 2.3.2
Development

No branches or pull requests
1 participant
@joewing