Update for Cabal >= 2.2 and base >= 4.11
#3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2, which is
Setup.hsnot working for Cabal > 2.0.1.1, and an issue without a ticket, which isbase>= 4.11 breaking the Monoid instance.I have not tested anything except compilation with Cabal 3.10.1.0 and
base4.17.2.0 (GHC 9.4.7). It should also work onbase4.18/GHC 9.6, and I've tried to maintain backward-compatibility with older Cabal/GHC/baseversions, too.While I didn't test compilation with older versions, my HLS seemed to be smart enough to pick up on the CPP macros and warn me about, e.g.
mappendbeing(<>)(or vice versa, I forget) only on the older version when I copy-pasted a small piece of code. That same chunk of code didn't have the warning on the #ifdef pertaining to the version I had installed. That was pretty cool.