Disable static_assert in CNL_ASSERT_EQ

John McFarlane · John McFarlane · commit 95f4aa4a9fb3 · 2022-05-26T00:58:25.000+01:00
diff --git a/include/cnl/_impl/charconv/to_chars.h b/include/cnl/_impl/charconv/to_chars.h
@@ -110,7 +110,7 @@ namespace cnl {
         }
 
         using native_rounding_type = set_rounding_t<decltype(value), native_rounding_tag>;
-        auto const& native_rounding_value = static_cast<native_rounding_type>(value);
+        auto const& native_rounding_value = static_cast<native_rounding_type const&>(value);
 
         return _impl::to_chars_non_zero<native_rounding_type>(
                 first, last, native_rounding_value, base);
diff --git a/test/framework/test.h b/test/framework/test.h
@@ -16,7 +16,6 @@
 
 // NOLINTNEXTLINE(cppcoreguidelines-macro-usage)
 #define CNL_ASSERT_EQ(a, b) \
-    static_assert(identical(a, b)); \
     ASSERT_EQ(a, b);
 
 // cnl::_impl::identical - compiles iff same type; returns true iff equal

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ namespace cnl {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`using native_rounding_type = set_rounding_t<decltype(value), native_rounding_tag>;`
`113`		`- auto const& native_rounding_value = static_cast<native_rounding_type>(value);`
	`113`	`+ auto const& native_rounding_value = static_cast<native_rounding_type const&>(value);`
`114`	`114`
`115`	`115`	`return _impl::to_chars_non_zero<native_rounding_type>(`
`116`	`116`	`first, last, native_rounding_value, base);`