Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Remove direct dependency to ajax.googleapis.com (privacy issue) #30

Open
tetraf opened this issue May 20, 2013 · 7 comments · May be fixed by #42
Open

[patch] Remove direct dependency to ajax.googleapis.com (privacy issue) #30

tetraf opened this issue May 20, 2013 · 7 comments · May be fixed by #42

Comments

@tetraf
Copy link

tetraf commented May 20, 2013

Patch to use with git apply: https://gist.github.com/tetraf/5611870

@alexandre-mbm
Copy link

Is @johnmckerrell no longer maintaining this repository? If I made a pull request with the patch above, would it be accepted?

@johnmckerrell
Copy link
Owner

I'm still here but don't get time to do anything with OSV, if you submit a pull request I should be able to apply it.

@alexandre-mbm
Copy link

Thank you. I will do some requests in the coming days.

Can you tell which is the license you want to use?

@alexandre-mbm
Copy link

I have a local branch for pull request. I used the tips about git apply. I made the fixes about which I commented at the Gist tetraf/remove_googleapis.patch. I ran a quick test and it showed no problems.

Accepting the pull request will entail accepting the jQuery's code dual licensed under the MIT (MIT-LICENSE.txt) and GPL (GPL-LICENSE.txt) licenses. Do I send the pull request?

@johnmckerrell
Copy link
Owner

Yes please do, I think it's fine to do that as a library.

On 13 Mar 2014, at 11:44, Alexandre Magno notifications@github.com wrote:

I have a local branch for pull request. I used the tips about git apply. I made the fixes about which I commented at the Gist tetraf/remove_googleapis.patch. I ran a quick test and it showed no problems.

Accepting the pull request will entail accepting the jQuery's code dual licensed under the MIT (MIT-LICENSE.txt) and GPL (GPL-LICENSE.txt) licenses. Do I send the pull request?


Reply to this email directly or view it on GitHub.

@alexandre-mbm
Copy link

But we would be redistributing it. No problem?

@johnmckerrell
Copy link
Owner

I'm going to say "Yes", no problem. I believe it's ok as a library.

On 13 Mar 2014, at 12:10, Alexandre Magno notifications@github.com wrote:

But we are redistributing it. No problem?


Reply to this email directly or view it on GitHub.

alexandre-mbm added a commit to alexandre-mbm/OpenStreetView that referenced this issue Mar 13, 2014
@alexandre-mbm alexandre-mbm linked a pull request Mar 13, 2014 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants