Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for query parameters "noglobal" and "notrycatch". #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for query parameters "noglobal" and "notrycatch". #28

wants to merge 2 commits into from

Conversation

lehni
Copy link

@lehni lehni commented Jan 16, 2016

Closes #22.

@jonkemp
Copy link
Owner

jonkemp commented Jan 19, 2016

Is it possible to add tests for this?

@lehni
Copy link
Author

lehni commented Jan 19, 2016

I can try for sure!

@lehni
Copy link
Author

lehni commented Jan 19, 2016

BTW, is there a reason for gulp-util to appear both in dependencies and devDependencies?

@lehni
First attempt at implementing unit test for noGlobals option.
87811ae 
It does not seem to work yet, not sure why.
@lehni
Copy link
Author

lehni commented Jan 19, 2016

87811ae doesn't seem to do it yet... Could you have a look and tell me what I am doing wrong?

@jonkemp
Copy link
Owner

jonkemp commented May 25, 2016

Looks like everything is good here. Sorry for the lack of response. Is there any reason not to merge this?

@lehni
Copy link
Author

lehni commented Mar 21, 2022

@jonkemp no, this good to go since 6 years :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing "?noglobals=true" to the loaded qunit html file
2 participants
@lehni @jonkemp