Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gulp-qunit.finished event emitted to wrong target #38

Open
jareguo opened this issue Jun 7, 2018 · 1 comment
Open

gulp-qunit.finished event emitted to wrong target #38

jareguo opened this issue Jun 7, 2018 · 1 comment
Labels
bug help wanted

Comments

@jareguo
Copy link

jareguo commented Jun 7, 2018

In https://github.com/jonkemp/gulp-qunit/pull/13/files, the event was emitted to gulp stream. (because this binded to through)
But in 734543f, the event was emitted to the child process. So users cannot listen to the event from outside.
@jonkemp
Copy link
Owner

jonkemp commented Jun 7, 2018

Oh, oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonkemp @jareguo