Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid XHTML #29

Open
dsieger opened this issue Jul 1, 2021 · 2 comments
Open

Invalid XHTML #29

dsieger opened this issue Jul 1, 2021 · 2 comments

Comments

@dsieger
Copy link

dsieger commented Jul 1, 2021

Hi,

First of all: Thanks for your work, this is indeed awesome. I did something similar for our project documentation, but your solution is much cleaner and more comprehensive. I immediately adopted it, see our user guide for an example. I did some minor changes, mostly to the sidebar, maybe you are interested in some of those.

Anyway, the main issue I had was invalid XHTML markup: If you run your site through the W3C validator you'll notice a couple of issues you might want to fix.

Thanks,
Daniel
@jothepro
Copy link
Owner

jothepro commented Jul 1, 2021

Thanks for pointing that out, it seems like I have mixed in some html5 by accident...

Thanks for sending me a link of your documentation, it's always helpful to see what others do with the theme!
I like the style of the arrows in the sidebar! It seems like the adjustments that you made don't work for the dark theme, though:

Bildschirmfoto 2021-07-01 um 18 04 14

If you don't want / don't care about dark mode you will be able to disable it in the upcoming release by setting

<html class="light-mode">

@dsieger
Copy link
Author

dsieger commented Jul 1, 2021

Thanks for spotting, fixed. Only tested dark mode on mobile.

For the arrows I simply override the icon used in navtree.js by adding a snippet to my header.html:

<script type="text/javascript">
  var arrowRight = '&#9655;';
</script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsieger @jothepro