Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to check which version of theme that you have? #49

Open
jdillard opened this issue Oct 5, 2021 · 2 comments
Open

Is there a way to check which version of theme that you have? #49

jdillard opened this issue Oct 5, 2021 · 2 comments
Labels
question Further information is requested

Comments

@jdillard
Copy link

jdillard commented Oct 5, 2021

I looked at doxygen-awesome.css for a version number and didn't see one. Is there currently a way to check with version of the theme files you have if you didn't use the submodule method? If not, would it worthwhile adding version information to the static files (some or all)?

@jdillard jdillard changed the title Is there a way to check which version of css that you have? Is there a way to check which version of theme that you have? Oct 5, 2021
@jothepro jothepro added the question Further information is requested label Oct 7, 2021
@jothepro
Copy link
Owner

jothepro commented Oct 8, 2021

I currently cannot think of an easy way on how the version information could be included in the files. 🤔 If I was hardcoding a version in there, this would be misleading if someone downloaded the current HEAD (e.g. the file would say "1.6.0" but it includes changes from the HEAD that have not yet been released).
Maybe I could achieve sth like this by introducing a more complex branching model where the pipeline is automatically adding version information when merging into master, but I don't think it's worth introducing all the complexity.

If you copy the files instead of using a submodule, maybe the easiest solution for you is to add the version number to the file manually when you copy the file?

@jdillard
Copy link
Author

jdillard commented Oct 8, 2021

Maybe I could achieve sth like this by introducing a more complex branching model where the pipeline is automatically adding version information when merging into master, but I don't think it's worth introducing all the complexity.

Very true. Instead of basing it off the branching model, you can check if the current commit is tagged and add logic based on that, like maybe prepend the name of the tag to specific published files (although prepending text isn't exactly a clean operation in bash). Something like:

tag=$(git tag --points-at 2>/dev/null || true)

if [ -z ${tag} ]; then
    echo "This commit not tagged."
    exit 0
fi

# tag exists append tag to files, etc
[...]

I understand that still adds complexity though, so just throwing ideas out.

If you copy the files instead of using a submodule, maybe the easiest solution for you is to add the version number to the file manually when you copy the file?

Totally happy to do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants