Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heroku_san should support https://git.heroku.com/ repo URIs as a configurable option #173

Open
jikamens opened this issue Dec 28, 2015 · 2 comments

Comments

@jikamens
Copy link

Heroku seems to be encouraging people to use https://git.heroku.com/ repo URIs rather than git@github.com: URIs, i.e., https instead of ssh. Heroku_san should at least allow this as an option, if not make it the default.

Note that this would fix #165, a long-standing bug which really deserves a better fix than a workaround buried in the comments of an open issue. Since Heroku now supports and recommends the accounts plugin to the toolbelt, heroku_san should be able to deal with it.

@kmayer
Copy link
Contributor

kmayer commented Jan 2, 2016

I agree! I've been unable to work on this fix for months, but maybe today
is the day. I have some time off :-)

On Mon, Dec 28, 2015 at 10:44 AM, Jonathan Kamens notifications@github.com
wrote:

Heroku seems to be encouraging people to use https://git.heroku.com/ repo
URIs rather than git@github.com: URIs, i.e., https instead of ssh.
Heroku_san should at least allow this as an option, if not make it the
default.

Note that this would fix #165
#165, a
long-standing bug which really deserves a better fix than a workaround
buried in the comments of an open issue. Since Heroku now supports and
recommends the accounts plugin to the toolbelt, heroku_san should be able
to deal with it.


Reply to this email directly or view it on GitHub
#173.

ken@bitwrangler.com | (808) 722-6142 (c)

@kmayer
Copy link
Contributor

kmayer commented Mar 12, 2016

A breaking test would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants