Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Selectmenu: Find label when <select> element has weird ID #7401

Closed
gabrielschulhof opened this issue May 14, 2014 · 3 comments
Closed

Selectmenu: Find label when <select> element has weird ID #7401

gabrielschulhof opened this issue May 14, 2014 · 3 comments

Comments

@gabrielschulhof
Copy link

This issue is similar to #6052, except this breaks the page, because autoinit of the <select> element fails so the whole autoinit is torn down, leaving the loader in place forever.

@gabrielschulhof
Copy link
Author

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone May 14, 2014
@gabrielschulhof gabrielschulhof self-assigned this May 14, 2014
@gabrielschulhof gabrielschulhof changed the title Selectmenu: Find label when <select> element has weird ID Selectmenu: Find label when <select> element has weird ID May 14, 2014
@gabrielschulhof
Copy link
Author

Boy! This issue reveals problems in the popup widget too. It's not sufficient to escape the ID when looking for the label. A custom selectmenu with a weird ID will cause a popup with a weird ID to be created, as well as a popup container, popup screen, listview, etc. The ID needs to be escaped in all selectors.

@gabrielschulhof gabrielschulhof modified the milestones: 1.5 - 2.0, 1.4.3 May 14, 2014
@gabrielschulhof
Copy link
Author

Oh, and let's not forget pagecontainer. The dialog generated for the selectmenu when the menu is large also has an ID based on the ID of the selectmenu, so if the selectmenu's ID is weird, so will the dialog's be, and so will its data-url attribute.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants