Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Inline select is not inline #5838

Closed
mrextreme opened this issue Apr 2, 2013 · 4 comments
Closed

Inline select is not inline #5838

mrextreme opened this issue Apr 2, 2013 · 4 comments

Comments

@mrextreme
Copy link

When we display inline selects, they are formatted as inline so their width is not 100% but automatic, however the encapsulating div is still styled as block and not as inline or inline-block, so an inline select still occupies a whole - mostly empty - line, and we cannot put anything next to them.

jQM 1.3.0

Example code: http://jsbin.com/upenoj/1/

My quick fix for that is

.inline-block
{
    display: inline-block;
}

And in the assembled jQM 1.3.0 JS file, in _preExtension(), at line 9761 ( just before "this.select = this.element.removeClass" :

if( $.data( this.element[0], 'inline' ) )
    classes += " inline-block";

I tried it with data-inline="true", "false" and no data-inline whatsoever, and it worked all three times perfectly.

@mrextreme
Copy link
Author

By the way, after applying this fix, data-shadow="true" on a select (which just is a good old button) suddenly makes sense.

@jaspermdegroot
Copy link
Contributor

Agreed. The wrapper should be inline as well or there shouldn't be a wrapper at all.

@mrextreme
Copy link
Author

1.4.0? Damn...

@jaspermdegroot
Copy link
Contributor

@mrextreme

To fix this we have to make changes to markup or add the style classes to a different element. Bigger changes like that shouldn't go in a maintenance release so I set the milestone to the next point release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants