Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Autogrow: calculated height contains border height #6180

Closed
wants to merge 2 commits into from
Closed

Autogrow: calculated height contains border height #6180

wants to merge 2 commits into from

Conversation

jhogervorst
Copy link
Contributor

Fixes #6178

…tinput: height not correctly calculated due to box-sizing
@jhogervorst
Copy link
Contributor Author

Did someone take a look at this PR yet? If it's approved I make PRs for #6179 and #5688 as well.

@arschmitz arschmitz closed this in 48139f8 Aug 6, 2013
@arschmitz
Copy link
Contributor

@jhogervorst Thanks for the pr there were conflicts that prevented an automatic merge so i just manually applied changes thanks for the PR!

@jhogervorst jhogervorst deleted the issue-6178 branch August 6, 2013 10:51
@jhogervorst
Copy link
Contributor Author

@arschmitz Thanks! Could I've prevented those conflicts from happening?

@arschmitz
Copy link
Contributor

It was because we made changes since then. You could have fixed them and updated the PR but in the intrest of time and since the change was simple i thought it best to just manually apply these.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textinput: height not correctly calculated due to box-sizing
2 participants