You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
I came across this issue while fixing #6554. The quick solution was to check if I had already instantiated the back button, but we need to check why the function _addBackButton() is getting called twice during toolbar instantiation.
It looks like _addBackButton() is getting called from _setOptions() both times, so we need to figure out why _setOptions() runs twice during instantiation. It should not run at all.
The text was updated successfully, but these errors were encountered:
Obviously, this isn't a fix since now _makeFixed() is never called but it's getting us closer. Also, I see that _create() calls _makeFixed() and _makeFixed() calls _setOptions(), but _setOptions() calls _makeFixed() again. That doesn't seem right.
Note by Gabriel Schulhof <gabriel.schulhof@intel.com>: Edited commit message to
comply with new style guide and replaced author with real name.
Fixesgh-6567
I came across this issue while fixing #6554. The quick solution was to check if I had already instantiated the back button, but we need to check why the function _addBackButton() is getting called twice during toolbar instantiation.
It looks like _addBackButton() is getting called from _setOptions() both times, so we need to figure out why _setOptions() runs twice during instantiation. It should not run at all.
The text was updated successfully, but these errors were encountered: