Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

clicking tab header inside panel causes panel to close #6693

Closed
koosvanderkolk opened this issue Nov 4, 2013 · 2 comments
Closed

clicking tab header inside panel causes panel to close #6693

koosvanderkolk opened this issue Nov 4, 2013 · 2 comments
Assignees
Milestone

Comments

@koosvanderkolk
Copy link

I have a panel containing tabs. Clicking one of the tabs causes the panel to close, even if it has data-dismissible="false"

Demo: http://jsbin.com/ASOHeSE/3/edit

[Edit by @gabrielschulhof] Tested with 1.4.0-rc.1

@gabrielschulhof
Copy link

The panel's click handler was missing an event.isDefaultPrevented() filter. It now has it. The change will land in 1.4.1.

@ghost ghost assigned gabrielschulhof Nov 5, 2013
@koosvanderkolk
Copy link
Author

Cool, thanks!

gabrielschulhof pushed a commit that referenced this issue Dec 20, 2013
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.

Fixes #6693
gabrielschulhof pushed a commit that referenced this issue Jan 27, 2014
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.

Fixes #6693
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants