autogrow._handleShow should only bind to browser's transition end event (memory leak)

[nonplus]

Right now, the autoshow._handleShow() function binds once to three flavors of the transition end event: one("transitionend webkitTransitionEnd oTransitionEnd"). Since a browser is only going to fire (at most) one of these events (IE will fire none of them), the other event subscriptions won't ever be released.

The following code is the culprit:

if ( event.type !== "popupbeforeposition" ) {
    this.element
        .addClass( "ui-textinput-autogrow-resize" )
        .one( "transitionend webkitTransitionEnd oTransitionEnd",
            $.proxy( function() {
                this.element.removeClass( "ui-textinput-autogrow-resize" );
            }, this ) );
}

The fix should be to bind to the specific transition end event (if the browser has one). For example, the following is an example of a fixed implementation:

var transitionEndEvent = 'WebkitTransition' in window ? 'webkitTransitionEnd'
    : 'OTransition' in window ? 'oTransitionEnd'
    : 'MozTransition' in window || 'transition' in window ? 'transitionend'
    : undefined;

if ( event.type !== "popupbeforeposition" && transitionEndEvent) {
    this.element
        .addClass( "ui-textinput-autogrow-resize" )
        .one( "transitionend webkitTransitionEnd oTransitionEnd",
            $.proxy( function() {
                this.element.removeClass( "ui-textinput-autogrow-resize" );
            }, this ) );
}

However, there is probably a better place to configure the transitionEndEvent variable so that it can be reused by other widgets (e.g. panel.js)

[gabrielschulhof]

$.support might be a good place for storing the value of that conditional.

[nonplus]

I assume you mean $.**mobile.**support. I'm not sure what the correct naming conventions are and it seems that most of the support properties are Boolean rather than string values (though since an event name is truthy, that shouldn't be a problem).

In this case, would the name be $.mobile.support.transition.end?