Navigation Menu

Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Closing a popup with a header in combination with a page toolbar-header #6939

Closed
DickvdBrink opened this issue Jan 14, 2014 · 0 comments
Closed

Closing a popup with a header in combination with a page toolbar-header #6939

DickvdBrink opened this issue Jan 14, 2014 · 0 comments
Labels
Component: Popup
Milestone
1.4.4

Comments

@DickvdBrink
Copy link
Contributor

When you have a page with a fixed-toolbar header and a popup with a toolbar calling destroy on the popup breaks the page style. It removes the padding-top from the page which causes my element to fall under page header.

I've created a testcase:
http://jsfiddle.net/J2Pbd/1/

Tested in chrome using jQuery mobile 1.4
@DickvdBrink DickvdBrink mentioned this issue Jan 23, 2014
Closed
cgack added a commit to cgack/jquery-mobile that referenced this issue Mar 17, 2014
@cgack
Toolbar: removing popup removes page-header-fixedclass
78bd5b3 
Fixes jquery-archive#6987
Fixes jquery-archive#6939
@cgack cgack mentioned this issue Mar 17, 2014
Closed
@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone Mar 20, 2014
cgack added a commit to cgack/jquery-mobile that referenced this issue May 29, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
41ad1ab 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 2, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
50e7c8b 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 6, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
95579f0 
Adds _destroy to toolbar.js and _super() for fixedToolbar

Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
@jaspermdegroot jaspermdegroot modified the milestones: 1.4.4, 1.4.3 Jun 18, 2014
cgack added a commit to cgack/jquery-mobile that referenced this issue Jul 31, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
5282fa1 
adding tests for toolbar

Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Jul 31, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
2a90b14 
Some cleanup from pr review and added more destroy tests

Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Aug 28, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
f7fefb9 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Aug 29, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
2457d2a 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
0c46cc9 
Fixes jquery-archivegh-6978
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
1a56fcf 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
2aaac08 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014
@cgack
Toolbar: removing popup removes page-header-fixed class
1cc1611 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
arschmitz pushed a commit that referenced this issue Sep 12, 2014
@cgack @arschmitz
Toolbar: Sorts our proper destroy methods for toolbar and fixedtoolbar
98ece81 
Fixes gh-6987
Fixes gh-6939
Closes gh-7252

(cherry picked from commit 3efe6fe)
agcolom pushed a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@cgack @agcolom
Toolbar: Sorts our proper destroy methods for toolbar and fixedtoolbar
5726407 
Fixes jquery-archivegh-6987
Fixes jquery-archivegh-6939
Closes jquery-archivegh-7252
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: Popup
Projects
None yet
Milestone
1.4.4
Development

Successfully merging a pull request may close this issue.

Fixed Toolbar: removing popup removes ui-page-header-fixed class cgack/jquery-mobile
3 participants
@DickvdBrink @gabrielschulhof @jaspermdegroot