Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Listview: Improve performance #7227

Closed
gabrielschulhof opened this issue Mar 9, 2014 · 0 comments
Closed

Listview: Improve performance #7227

gabrielschulhof opened this issue Mar 9, 2014 · 0 comments
Assignees
@gabrielschulhof
Labels
Component: Listview
Milestone
1.4.3

Comments

@gabrielschulhof
Copy link

  • The list of anchors which is computed in the innermost loop is always reduced via .first(), even though in many cases there is only one anchor in the list. There is already special casing for when an li contains multiple anchors (split button), so we can improve the performance of all non-split-button-lists by avoiding an unnecessary call to .first()
  • addFirstLastClasses() uses .not( ".ui-screen-hidden" ). This can be evaluated faster using a custom function that parses .className.
@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone Mar 9, 2014
@gabrielschulhof gabrielschulhof self-assigned this Mar 9, 2014
gabrielschulhof pushed a commit that referenced this issue Mar 9, 2014
addFirstLastClasses: .not( ".ui-screen-hidden" ) -> custom function
81fa323 
http://jsperf.com/dot-not-vs-loop

Fixes gh-7227
@gabrielschulhof gabrielschulhof mentioned this issue Mar 9, 2014
Closed
gabrielschulhof pushed a commit that referenced this issue Mar 14, 2014
addFirstLastClasses: .not( ".ui-screen-hidden" ) -> custom function
5b9cc9f 
http://jsperf.com/dot-not-vs-loop

Fixes gh-7227
gabrielschulhof pushed a commit that referenced this issue May 29, 2014
addFirstLastClasses: .not( ".ui-screen-hidden" ) -> custom function
df691e6 
http://jsperf.com/dot-not-vs-loop

(cherry picked from commit 7b818d8)

Closes gh-7228
Fixes gh-7227
agcolom pushed a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@agcolom
addFirstLastClasses: .not( ".ui-screen-hidden" ) -> custom function
36478b1 
http://jsperf.com/dot-not-vs-loop

Closes jquery-archivegh-7228
Fixes jquery-archivegh-7227
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielschulhof gabrielschulhof

Labels
Component: Listview
Projects
None yet
Milestone
1.4.3
Development

Successfully merging a pull request may close this issue.

Listview performance improvements jquery-archive/jquery-mobile
1 participant
@gabrielschulhof