Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Selectmenu: Use placeholder for dialog title, not label #7399

Closed
gabrielschulhof opened this issue May 14, 2014 · 1 comment
Closed

Selectmenu: Use placeholder for dialog title, not label #7399

gabrielschulhof opened this issue May 14, 2014 · 1 comment
Assignees
@gabrielschulhof
Labels
Component: Selectmenu
Milestone
1.4.3

Comments

@gabrielschulhof
Copy link

For consistency with the popup-based version, the dialog-based selectmenu should use the placeholder menu item, if any, rather than the label associated with the selectmenu, like it does now.
@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone May 14, 2014
@gabrielschulhof gabrielschulhof self-assigned this May 14, 2014
@gabrielschulhof
Copy link
Author

The problem is in _decideFormat(). There's another problem too: We're using self.label.text() to set the title of the dialog, not self.label.getEncodedText(), which #2547 and #2550 have established is the right way to copy text from one part of the DOM to another while avoiding potential XSS issues.

gabrielschulhof pushed a commit that referenced this issue May 14, 2014
Select: Custom select uses label, then placeholder for dialog title
03db6ab 
Fixes gh-7399
@gabrielschulhof gabrielschulhof mentioned this issue May 14, 2014
Closed
gabrielschulhof pushed a commit that referenced this issue May 27, 2014
Selectmenu: Custom select uses label, then placeholder for dialog title
7342344 
(cherry picked from commit 1b836ee)

Closes gh-7404
Fixes gh-7399
agcolom pushed a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@agcolom
Selectmenu: Custom select uses label, then placeholder for dialog title
3dac6b7 
Closes jquery-archivegh-7404
Fixes jquery-archivegh-7399
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielschulhof gabrielschulhof

Labels
Component: Selectmenu
Projects
None yet
Milestone
1.4.3
Development

Successfully merging a pull request may close this issue.

Select: Custom select uses label, then placeholder for dialog title jquery-archive/jquery-mobile
1 participant
@gabrielschulhof